bug#66551: [PATCH] Add completion for Unix 'doas' command.

[Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Stefan Kangas <stefankangas@gmail.com> writes:

> Could you send an updated patch based on the above?

Patch is attached.

After some more testing I replaced:
(pcomplete-entries nil #'file-regular-p)
with:
(pcomplete-entries)

because the former makes it difficult to traverse directories to get to
the config file, and I've never seen pcomplete work like that anywhere
else.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-completion-for-Unix-doas-command.patch --]
[-- Type: text/x-patch, Size: 1657 bytes --]

From e00d8af1e17853def979d88efd80624a2793bad3 Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@mailbox.org>
Date: Sun, 15 Oct 2023 00:32:57 +0000
Subject: [PATCH] Add completion for Unix 'doas' command.

* lisp/pcmpl-unix.el (pcomplete/doas): New procedure.
* etc/NEWS: Announce.  (Bug#66551)

Co-authored-by: Visuwesh <visuweshm@gmail.com>
---
 etc/NEWS           | 4 ++++
 lisp/pcmpl-unix.el | 8 ++++++++
 2 files changed, 12 insertions(+)

diff --git a/etc/NEWS b/etc/NEWS
index 3bd47a0112b..d73ec031d85 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -477,6 +477,10 @@ When this option is non-nil, remote file names are not completed by
 Pcomplete.  Packages, like 'shell-mode', could set this in order to
 suppress remote file name completion at all.
 
+---
+*** Completions for the Unix 'doas' command are now provided.
+Command completion for 'doas' in Eshell and Shell mode will now work.
+
 ** Shell Mode
 
 +++
diff --git a/lisp/pcmpl-unix.el b/lisp/pcmpl-unix.el
index e6b67256a4c..7af5f2bce74 100644
--- a/lisp/pcmpl-unix.el
+++ b/lisp/pcmpl-unix.el
@@ -685,6 +685,14 @@ Includes files as well as host names followed by a colon."
   (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
 	       pcomplete-default-completion-function)))
 
+;;;###autoload
+(defun pcomplete/doas ()
+  "Completion for the `doas' command."
+  (pcomplete-opt "C(pcomplete-entries)Lnsu(pcmpl-unix-user-names)")
+  (funcall pcomplete-command-completion-function)
+  (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
+               pcomplete-default-completion-function)))
+
 (provide 'pcmpl-unix)
 
 ;;; pcmpl-unix.el ends here
-- 
2.41.0