From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 22:13:14 +0100 Message-ID: <87r0kgb2c5.fsf@sappc2.fritz.box> References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> <83cyw1gffr.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Eli Zaretskii , monnier@iro.umontreal.ca, 67005@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 22:14:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6H1a-0008YQ-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 22:14:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6H1L-0002qR-NX; Thu, 23 Nov 2023 16:13:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6H1K-0002qG-Bk for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:13:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6H1K-0006mK-31 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:13:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6H1N-0000Qi-Nb for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17007740241616 (code B ref 67005); Thu, 23 Nov 2023 21:14:01 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 21:13:44 +0000 Original-Received: from localhost ([127.0.0.1]:35232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6H15-0000Q0-NV for submit@debbugs.gnu.org; Thu, 23 Nov 2023 16:13:44 -0500 Original-Received: from mr4.vodafonemail.de ([145.253.228.164]:37972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6H13-0000Po-UQ for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 16:13:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1700774012; bh=YqRN26Iu+m0cJ8XCdooj2eFRp8hhfbg2maAIAdAG00k=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=jemB5hkZPDWRrZlposdW1R3PKr/i7V7Spjp8b8thDJE5QTq1ik3vxU+nFg8awiRGJ hiWOte0LBrMu/Df3LHvoStVFgWcKu/ApbaErMCeRku49Frk17DwNrnCzKeKmXJN4sK BrgtbV98uItWUvQvWmFsZi1layHhwRvQH4ZFVGOI= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4SbrSX18Y1z1xy4; Thu, 23 Nov 2023 21:13:32 +0000 (UTC) Original-Received: from sappc2 (port-92-196-82-109.dynamic.as20676.net [92.196.82.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4SbrSG2P9zz9s8Q; Thu, 23 Nov 2023 21:13:15 +0000 (UTC) In-Reply-To: (Andrea Corallo's message of "Thu, 23 Nov 2023 10:01:08 -0500") X-purgate-type: clean X-purgate: clean X-purgate-size: 2122 X-purgate-ID: 155817::1700774007-5BFFC7FF-2CD55FA3/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274831 Archived-At: Andrea Corallo writes: > Eli Zaretskii writes: > >> Does this patch resolve the 2 TODO items you are now deleting? Or >> were they already resolved by previous changes, and we just failed to >> keep the comments up-to-date? > > I'd say the second. Exactly. Sorry for not mentioning. My reasoning for removing these TODO items was as follows, easy one (?) first: >> - ;; - obsolete advice.el. - The main entry point to "advice.el", macro `defadvice', is declared obsolete as follows: (declare (doc-string 3) (indent 2) (obsolete "use `advice-add' or `define-advice'" "30.1") - The Elisp manual mentions that as well in "(elisp) Porting Old Advice". - Users are complaining about obsoletion on emacs-devel (but that is probably not a good criterion). >> - ;; - change all defadvice in lisp/**/*.el. This one is a bit harder. So first a bit of find and grep, commented and lacking the required line continuation for better readability: find . -type f ! -path ./lisp/emacs-lisp/advice.el # testing defadvice compatibility ! -path ./test/lisp/emacs-lisp/nadvice-tests.el # generated files ! -path ./lisp/TAGS ! -path ./lisp/ldefs-boot.el ! -path ./lisp/loaddefs.el ! -name '*.info' ! -name '*.el[cn]' ! -name '*.pdmp' # collateral ! -name '*ChangeLog*' ! -name '*NEWS*' -exec grep --color=auto -nH --null -e defadvice '{}' + Then I manually traced the results to find references to old advices, where they are not explicitly referred to as old ones. There are some such references in comments, docstrings, font lock defs, etc., and some of these probably should even be cared about. But there are only two instances where an advice is defined by means of `defadvice': # I didn't count that one as living in lisp/**/*.el ./test/manual/cedet/tests/test.el:75 # this one is explicitly tagged as backward compatibility hack for # "Emacs < 22 and XEmacs" ./lisp/progmodes/cc-mode.el:2733