[Monday December 11, 2023] Eli Zaretskii wrote: >> Cc: 67764@debbugs.gnu.org >> From: Visuwesh >> Date: Mon, 11 Dec 2023 17:10:01 +0530 >> >> > emacs -Q >> > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") >> > >> > On master it fails with "Wrong type argument: stringp, nil". >> > Bisect says 4254544 is the first bad commit. >> >> Recent changes in shr-put-image didn't account for the possible nil >> value for ALT. Attached patch fixes the issue on my end. >> >> >> >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 >> From: Visuwesh >> Date: Mon, 11 Dec 2023 17:09:03 +0530 >> Subject: [PATCH] ; Fix shr-put-image with nil value for ALT >> >> [...] >> > Thanks, but can we please avoid running a fixed string through > string-trim? > > Also, I think the fallback on "*" deserves a comment to explain why > that is done. OK, how about the attached instead?