From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS: scroll-bars Date: Tue, 07 May 2024 08:07:04 +0200 Message-ID: <87r0eeyx2v.fsf@gmail.com> References: <875xvvp3fo.fsf@gmail.com> <87r0eicht1.fsf_-_@gmail.com> <87plu29lcc.fsf@yahoo.com> <87fruyccs8.fsf@gmail.com> <878r0q9dzd.fsf@yahoo.com> <87a5l4r8xu.fsf@gmail.com> <86jzk8cipc.fsf@gnu.org> <87jzk8p26y.fsf@gmail.com> <86bk5kceq6.fsf@gnu.org> <86jzk7aslr.fsf@gnu.org> <86edaebxvs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 07 08:08:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4Dzb-00049j-Vo for ged-emacs-devel@m.gmane-mx.org; Tue, 07 May 2024 08:07:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4Dys-0003tc-8k; Tue, 07 May 2024 02:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4Dyn-0003pm-GZ for emacs-devel@gnu.org; Tue, 07 May 2024 02:07:10 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4Dyl-0002Go-Sc; Tue, 07 May 2024 02:07:09 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a59a17fcc6bso591794366b.1; Mon, 06 May 2024 23:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715062026; x=1715666826; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=S5jz6Dwq0BeItjoGY9U3Z8fKBsEZ7SLJV3l1zlOtobc=; b=RoUMbXIrNVXaV56oJ7qWv8Yg2PynXuzcJj7n/PO9An+Da0Q4MUEXvc//E0O3XbAN9n 6Gkrwg1pSuwZaH2WUNSIeYNKyYGHnlt0D85WKanWsbp5dzR5Vfb1itnmpVlmHq6uGuXH wNgKfdW8gVh2mlemcUF/q/3TlmiFFG1raQa5LT9rqOB8sZYT5qt4JtbjoOdioCa9xDef hweydKljIF3QFzSMvFam91qHLhFPVxvDOdf/+cqHqZC1P7GP00cmcLzAylViHW6L2gXK +1zf9w+z2Ta355wrY3bvlXQIyVrxX5NIFikTRmUMxPkrjZadJ2+LszZ8r8xdniPzPALt IZEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715062026; x=1715666826; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S5jz6Dwq0BeItjoGY9U3Z8fKBsEZ7SLJV3l1zlOtobc=; b=NBSThzW7UOGgA+NTC6jG3RO0QrJTvOck4xxksHiebul5R4U4ZBlHNO0IKqdqpGU7HZ ILdf9wRD0nqJQD0JOg/mjHRoRzNZb9DeUeQhOC3Q78IQZkri8ucf/7KI2uf1S8WCFjR7 jZEhseI4mq8+bzwLn7JrcyYmKc7zoFrMDMh/X3Gxt+f0DocSSYb1ShHFBZagR8EmIorJ YDJ50O8idOzJeFaBh4pYqr052geW2tGklAEbxCL/D5TQBT6QqRv24ybruNr0Q4BFU6F4 kmKevJGNCt/7dL9u+sz/OkIDDLsNV1Nj9vx4DRvxVsaTVUJoVPLLlEsQa7WxS2XyTlLE sqHQ== X-Forwarded-Encrypted: i=1; AJvYcCVtsWxUmYFE+xm6BxKv2mq29UmzrXzOFB2ystB19WnmsRArXXLget5Y0N5/hBkNruD6t87TWRght6Tx1aFgUfQCKb/j X-Gm-Message-State: AOJu0Yy4Qs6Z2ubFHXGFrESYVXivzoK2VMtYQ76x6y4sSw4EyLkWxYAu jKv/kAEyZ2ktpXoS3BE0Lv6n2Kzsel4yNXFVhPzHz9hZFLCZL16nplaYjg== X-Google-Smtp-Source: AGHT+IE5cHnd0ifIvtPIqSQM0lxUCAgNp50/pe/eaHxmxESrTSN+gCcQ6HINExFU8tALoT0t/CDjVg== X-Received: by 2002:a50:8d5c:0:b0:571:bed1:3a27 with SMTP id t28-20020a508d5c000000b00571bed13a27mr7481281edt.38.1715062025325; Mon, 06 May 2024 23:07:05 -0700 (PDT) Original-Received: from caladan (dial-184253.pool.broadband44.net. [212.46.184.253]) by smtp.gmail.com with ESMTPSA id en23-20020a056402529700b0057310cb27e5sm690923edb.22.2024.05.06.23.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 23:07:04 -0700 (PDT) In-Reply-To: <86edaebxvs.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 06 May 2024 21:25:59 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=eller.helmut@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318921 Archived-At: On Mon, May 06 2024, Eli Zaretskii wrote: >> > Btw, did we decide what to do with these chains: >> > >> > struct frame >> > { >> > [...] >> > /* List of scroll bars on this frame. >> > Actually, we don't specify exactly what is stored here at all; the >> > scroll bar implementation code can use it to store anything it likes. >> > This field is marked by the garbage collector. It is here >> > instead of in the `device' structure so that the garbage >> > collector doesn't need to look inside the window-system-dependent >> > structure. */ >> > Lisp_Object scroll_bars; >> > Lisp_Object condemned_scroll_bars; >> > >> > They are doubly-linked lists via the ->next and ->prev fields in the C >> > 'struct scroll_bar', in X as well as w32, see XSCROLL_BAR. The >> > Lisp_Object's above are the last scroll bar on the frame's windows, >> > and the rest are reachable via the ->next and ->prev pointers. Do we >> > need to do anything about those ->next and ->prev pointers? [...] > Helmut, WDYT about the scroll bars on X (and by extension on w32)? On X, the struct scroll_bar is allocated as a PVEC_OTHER pseudovector. And I think the next/prev links are traced because of that. xterm.c:mark_xterm doesn't do anything special for scrollbars, so I think it's all covered. The only complication so far was that a struct scroll_bar* was handed to GTK that was not traced; after I turned that into a root with a pointer to the scroll_bar* it is traced.