From: Ihor Radchenko <yantar92@posteo.net>
To: Nafiz Islam <nafiz.islam1001@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] function and symbol for headline and olp for org-capture-templates
Date: Fri, 17 May 2024 12:48:00 +0000 [thread overview]
Message-ID: <87r0e08v0f.fsf@localhost> (raw)
In-Reply-To: <CAKjtFcQoqqDaGzTQ9z6vtr6QdoH4DikhvBDtXwKSYdfN3aZ9ow@mail.gmail.com>
Nafiz Islam <nafiz.islam1001@gmail.com> writes:
> This patch adds the option to provide function and symbol for headline and
> olp for org-capture-templates.
Thanks for the patch.
A few comments.
Firstly, your total contribution to Org mode with this patch will exceed
the maximum allowed number of LOC changes we can accept without FSF
copyright assignment. May I know if you have FSF copyright assignment?
If not, would you consider doing the paperwork? See
https://orgmode.org/worg/org-contribute.html#copyright
> - (string :tag " Headline"))
> + (choice :tag "Headline"
> + (string :tag "Headline")
> + (function :tag "Function")
> + (variable :tag "Variable")
> + (sexp :tag "Form")))
Please update the docstring of `org-capture-templates' as well.
> +(defun org-capture-expand-olp (&rest olp)
> + "Expand functions, symbols and outline paths for OLP.
> +When OLP is a function, call it. When it is a variable,
> +return its value. When it is a list of string, return it.
> +In any other case, return `nil'."
> + (let* ((final-olp (cond ((stringp (car olp)) olp)
> + (t (org-capture-expand-function-or-symbol (car olp))))))
> + final-olp))
I think that we should filter out incorrect target specifications when
the function name is followed by more list elements - (cdr olp) is non-nil.
> ...
> However, I just realized that the suggestion provided in
> https://lists.gnu.org/archive/html/emacs-orgmode/2024-05/msg00216.html
> might not work how I was hoping for. Basically, I wanted it to be possible
> to search for headlines and even outline paths in the
> buffer while in the function. But, by expanding outline-path before setting
> the buffer (by calling outside of `org-find-olp') that
> becomes infeasible.
I think that we may pass the file name as an argument to outline path
function.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-05-17 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 22:53 [PATCH] function and symbol for headline and olp for org-capture-templates Nafiz Islam
2024-05-13 23:08 ` Nafiz Islam
2024-05-17 12:48 ` Ihor Radchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-19 23:34 Nafiz Islam
2024-05-19 23:43 ` Nafiz Islam
2024-05-20 10:53 ` Ihor Radchenko
2024-05-21 21:00 ` Nafiz Islam
2024-05-22 11:11 ` Nafiz Islam
2024-05-22 11:15 ` Ihor Radchenko
2024-06-01 16:38 Nafiz Islam
2024-06-05 9:09 ` Ihor Radchenko
2024-06-05 21:16 ` Bastien Guerry
[not found] ` <f2b85669-a0fc-40c6-891a-1319d0582fe0@gmail.com>
[not found] ` <87frtpgj2w.fsf@localhost>
2024-06-09 14:59 ` Nafiz Islam
2024-06-09 17:03 ` Ihor Radchenko
[not found] ` <3508dbb0-a8ee-4217-af21-a9fc3ac46eb9@gmail.com>
[not found] ` <874ja4ak0q.fsf@localhost>
2024-06-15 21:45 ` Nafiz Islam
2024-06-16 12:20 ` Ihor Radchenko
[not found] ` <c98ba108-c07e-4c17-a806-524444367d9d@gmail.com>
[not found] ` <87plsfa2nt.fsf@localhost>
2024-06-18 12:05 ` Nafiz Islam
2024-06-18 12:36 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0e08v0f.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=nafiz.islam1001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.