[வியாழன் ஜூலை 25, 2024] Juri Linkov wrote: >>> > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to >>> > `query-replace-read-args', for stylistic reasons? >>> >>> It's not clear how such arg should be combined with >>> `query-replace-lazy-highlight' in `query-replace-read-args': >>> >>> (defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight) >>> ... >>> (from (minibuffer-with-setup-hook >>> (minibuffer-lazy-highlight-setup >>> :highlight query-replace-lazy-highlight >>> >>> with `and'? With `or'? With `xor'? >>> `(and query-replace-lazy-highlight (not no-highlight))'? >> >> The installed patch binds query-replace-lazy-highlight to nil and >> shadows the old binding. This would correspond to >> >> (and query-replace-lazy-highlight (not no-highlight)) >> >> which looks reasonable in this case: we just an argument to inhibit >> highlighting. Because we never want highlighting in some cases (like >> here). > > Agreed, let's add a new argument. So how about the attached patch?