From: "Sławomir Grochowski" <slawomir.grochowski@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [FR] org-colview.el, add annotation for functions summary-types
Date: Thu, 15 Aug 2024 19:29:15 +0200 [thread overview]
Message-ID: <87r0aplmok.fsf@gmail.com> (raw)
In-Reply-To: <878qwx3f6k.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Why not applying faces?
Because in case of 'annotation-function':
https://www.gnu.org/software/emacs/manual/html_node/elisp/Programmed-Completion.html
"...Unless this function puts own face on the annotation suffix string,
the completions-annotations face is added by default to that string.
>> (completing-read
>> "Summary: "
>> (lambda (s pred flag)
>> (pcase flag
>> ('t (all-completions s
>> (mapcar #'car org-columns-summary-types-default)
>> pred))
>> ('metadata (list 'metadata
>> (cons 'annotation-function
>> (lambda (c)
>> (first-line-docstring
>> (cdr (assoc c org-columns-summary-types-default))))))))))
>
> Looks reasonable.
> Although, I'd prefer to avoid lambda here and simply make it into a
> proper function. Just like `org-tags-completion-function'.
And this will be private function in colview.el?
With name... `org-columns--completion-summary-types-function' ?
--
Slawomir Grochowski
next prev parent reply other threads:[~2024-08-15 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:53 [FR] org-colview.el, add annotation for functions summary-types Sławomir Grochowski
2024-08-10 13:03 ` Ihor Radchenko
2024-08-15 14:35 ` Sławomir Grochowski
2024-08-15 16:48 ` Ihor Radchenko
2024-08-15 17:29 ` Sławomir Grochowski [this message]
2024-08-15 17:41 ` Ihor Radchenko
2024-08-16 11:13 ` Sławomir Grochowski
2024-08-18 9:56 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0aplmok.fsf@gmail.com \
--to=slawomir.grochowski@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.