all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Laurence Warne <laurencewarne@gmail.com>
Cc: mattiase@acm.org, 73441@debbugs.gnu.org, Sam James <sam@gentoo.org>
Subject: bug#73441: 31.0.50; Unstable proced-refine-test failure
Date: Tue, 29 Oct 2024 08:51:19 +0100	[thread overview]
Message-ID: <87r07z73ew.fsf@gmx.de> (raw)
In-Reply-To: <CAE2oLqhZR0yL9RBpX-CMKkFpCv99stOGwc1m2di1BEiFfcnQMg@mail.gmail.com> (Laurence Warne's message of "Sat, 26 Oct 2024 16:44:27 +0100")

Laurence Warne <laurencewarne@gmail.com> writes:

> Hi Michael,

Hi Laurence,

> Thanks for taking a look!  Ah I see, I thought that refining on the
> PID of a process only filtered the buffer to show the process and it's
> direct children but looking at 'proced-filter-children' this doesn't
> appear to be the case.
>
> I've attached a patch which changes the refinement tests to use the
> simpler CPU refinement behaviour (keep everything with %CPU >= process
> at point), which appears to work well.

I'll reopen this bug, because on emba there's still an error, occasionnally:

--8<---------------cut here---------------start------------->8---
Running 6 tests (2024-10-29 07:00:15+0000, selector `(not (tag :unstable))')
   passed  1/6  proced-color-test (0.027574 sec)
   passed  2/6  proced-format-test (0.156767 sec)
Test proced-refine-test backtrace:
  >=(nil 92.2)
  apply(>= (nil 92.2))
  proced--assert-process-valid-cpu-refinement(92.2)
  #f(compiled-function () #<bytecode 0x1b4b54e9d1659058>)()
  #f(compiled-function () #<bytecode -0x1703a0141b1acd6f>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x1703a0141b1acd6
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name proced-refine-test :documentation nil
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test proced-refine-test condition:
    (wrong-type-argument number-or-marker-p nil)
   FAILED  3/6  proced-refine-test (0.072968 sec) at lisp/proced-tests.el:83
   passed  4/6  proced-refine-with-update-test (0.042013 sec)
   passed  5/6  proced-revert-test (0.034675 sec)
   passed  6/6  proced-update-test (0.032764 sec)
Ran 6 tests, 5 results as expected, 1 unexpected (2024-10-29 07:00:15+0000, 0.533977 sec)
1 unexpected results:
   FAILED  proced-refine-test  number-or-marker-p
--8<---------------cut here---------------end--------------->8---

See for example <https://emba.gnu.org/emacs/emacs/-/jobs/92138#L1352>

> Thanks, Laurence

Best regards, Michael.





  parent reply	other threads:[~2024-10-29  7:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 13:19 bug#73441: 31.0.50; Unstable proced-refine-test failure Sam James
2024-09-27 13:00 ` Laurence Warne
2024-10-15 14:52   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-25 16:46     ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-26 15:44       ` Laurence Warne
2024-10-26 16:59         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-27 11:16           ` Laurence Warne
2024-10-27 11:47             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-27 12:07               ` Eli Zaretskii
2024-10-27 15:53                 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-29  7:51         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-29 21:26           ` Laurence Warne
2024-10-30 14:15             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-30 18:25               ` Laurence Warne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r07z73ew.fsf@gmx.de \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73441@debbugs.gnu.org \
    --cc=laurencewarne@gmail.com \
    --cc=mattiase@acm.org \
    --cc=michael.albinus@gmx.de \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.