From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Sat, 23 Nov 2024 21:14:13 +0200 Organization: LINKOV.NET Message-ID: <87r071oj96.fsf@mail.linkov.net> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> <86y11cnyws.fsf@gnu.org> <87iksfpwlr.fsf@mail.linkov.net> <86jzcvof10.fsf@gnu.org> <87h67xren9.fsf@mail.linkov.net> <864j3xlr2r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 20:19:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEvfG-0003tb-Ht for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 20:19:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEver-00058e-Ez; Sat, 23 Nov 2024 14:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEveo-00058L-Aq for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:19:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEveo-0004kW-1F for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Yo4SfM+4EqdhBaE0pdjDyc59n+RAaOqDyKbI22J6OpA=; b=hKylcsb2TJa51TtkUdF1S6V3gA1+JQn8JAZ6PCIUmHIaHQOsGk0ZCPkMFu5cVwzIJEF7lZhf5UqYnElL0PwcV6GQGRtKMMFX7MgpjwRkTP85N+JK4sk8u7Obn+sfzIDy1dhZZBrvhkZBJdWzo6QcAppBgj9oeh7nKzHlOPr93KKQ5NO/ckf1E7NpevLWKNKkQr8mH3Qgz/oCANXCJeN8BNMpBbLZxBTBV0Ztdd6sFVyyeRX3yNwna8r6qmtxAF3P6o+Bh/6Pw5onb5Fw2jHTmwus5JdJxxHytfKLnfpULLU87ohxxgQfnmFdnlfhTW6auU6UO2XQ62KbLKdcmZAuog==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEven-0000VI-MP for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.17323894871798 (code B ref 74361); Sat, 23 Nov 2024 19:19:01 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 23 Nov 2024 19:18:07 +0000 Original-Received: from localhost ([127.0.0.1]:59167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEvdv-0000Sw-7L for submit@debbugs.gnu.org; Sat, 23 Nov 2024 14:18:07 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEvdt-0000SE-1S for 74361@debbugs.gnu.org; Sat, 23 Nov 2024 14:18:05 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 4D05640002; Sat, 23 Nov 2024 19:17:56 +0000 (UTC) In-Reply-To: <864j3xlr2r.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Nov 2024 20:53:32 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295863 Archived-At: >> >> 1. Demote these options to variables not intended for customization. >> >> 2. Move their current default values to display-buffer calls. >> > >> > I expected to see us do #2 at the same time we deprecated the user >> > options. I don't understand why we didn't do that. The deprecation >> > message clearly tells users not to use these variables, so it's >> > reasonable to expect them to be deleted. Moreover, their presence in >> > our sources is a potential cause for byte-compilation warnings. >> >> Immediate #2 will break customization for many users. >> We have to give enough time between two releases >> to allow the users to see a warning and adapt their >> config files to upcoming deletion of these options. > > But isn't it true that if users adapt their config files, the > customization will stop working for them because category is not used > by comint? Adapting config files means replacing such settings (setopt display-comint-buffer-action '((display-buffer-same-window) (inhibit-same-window . nil))) with (add-to-list 'display-buffer-alist '((category . comint) (display-buffer-same-window) (inhibit-same-window . nil))) This already works since all corresponding display-buffer calls already provide the 'comint' category.