rcirc bugfixes

rcirc bugfixes

[Ryan Yeske]

2006-03-10  Ryan Yeske  <rcyeske@gmail.com>

	* net/rcirc.el (rcirc) <defgroup>: Add link to manual.
	(rcirc-print): Mark the start of text at the end of the prompt.
	(rcirc-track-minor-mode): Add autoload cookie.
	(rcirc-update-activity-string): Add space to front of mode-line
	indicator.

Index: rcirc.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/net/rcirc.el,v
retrieving revision 1.17
diff -c -r1.17 rcirc.el
*** rcirc.el	3 Mar 2006 11:43:27 -0000	1.17
--- rcirc.el	10 Mar 2006 22:32:15 -0000
***************
*** 50,55 ****
--- 50,56 ----
    "Simple IRC client."
    :version "22.1"
    :prefix "rcirc-"
+   :link '(custom-manual "(rcirc)")
    :group 'applications)
  
  (defcustom rcirc-server "irc.freenode.net"
***************
*** 883,889 ****
  (defun rcirc-multiline-edit-submit ()
    "Send the text in buffer back to parent buffer."
    (interactive)
!   (assert (and (eq major-mode 'rcirc-multiline-edit-mode)))
    (assert rcirc-parent-buffer)
    (untabify (point-min) (point-max))
    (let ((text (buffer-substring (point-min) (point-max)))
--- 884,890 ----
  (defun rcirc-multiline-edit-submit ()
    "Send the text in buffer back to parent buffer."
    (interactive)
!   (assert (eq major-mode 'rcirc-multiline-edit-mode))
    (assert rcirc-parent-buffer)
    (untabify (point-min) (point-max))
    (let ((text (buffer-substring (point-min) (point-max)))
***************
*** 899,905 ****
  (defun rcirc-multiline-edit-cancel ()
    "Cancel the multiline edit."
    (interactive)
!   (assert (and (eq major-mode 'rcirc-multiline-edit-mode)))
    (kill-buffer (current-buffer))
    (set-window-configuration rcirc-window-configuration))
  
--- 900,906 ----
  (defun rcirc-multiline-edit-cancel ()
    "Cancel the multiline edit."
    (interactive)
!   (assert (eq major-mode 'rcirc-multiline-edit-mode))
    (kill-buffer (current-buffer))
    (set-window-configuration rcirc-window-configuration))
  
***************
*** 1088,1094 ****
  	      (set-marker text-start
  			  (or (next-single-property-change fill-start 
  							   'rcirc-text)
! 			      (point-max)))
  	      ;; squeeze spaces out of text before rcirc-text
  	      (fill-region fill-start (1- text-start))
  
--- 1089,1095 ----
  	      (set-marker text-start
  			  (or (next-single-property-change fill-start 
  							   'rcirc-text)
! 			      rcirc-prompt-end-marker))
  	      ;; squeeze spaces out of text before rcirc-text
  	      (fill-region fill-start (1- text-start))
  
***************
*** 1253,1261 ****
  (define-key rcirc-track-minor-mode-map (kbd "C-c C-@") 'rcirc-next-active-buffer)
  (define-key rcirc-track-minor-mode-map (kbd "C-c C-SPC") 'rcirc-next-active-buffer)
  
! ;;; FIXME: the code to insert `rcirc-activity-string' into
! ;;; `global-mode-string' isn't called when the mode is activated by
! ;;; customize.  I don't know how to set that up.
  (define-minor-mode rcirc-track-minor-mode
    "Global minor mode for tracking activity in rcirc buffers."
    :init-value nil
--- 1254,1260 ----
  (define-key rcirc-track-minor-mode-map (kbd "C-c C-@") 'rcirc-next-active-buffer)
  (define-key rcirc-track-minor-mode-map (kbd "C-c C-SPC") 'rcirc-next-active-buffer)
  
! ;;;###autoload
  (define-minor-mode rcirc-track-minor-mode
    "Global minor mode for tracking activity in rcirc buffers."
    :init-value nil
***************
*** 1357,1363 ****
    (setq rcirc-activity-string
  	(if (not rcirc-activity)
  	       ""
! 	  (concat " ["
  		  (mapconcat
  		   (lambda (b)
  		     (let ((s (rcirc-short-buffer-name b)))
--- 1356,1362 ----
    (setq rcirc-activity-string
  	(if (not rcirc-activity)
  	       ""
! 	  (concat "-["
  		  (mapconcat
  		   (lambda (b)
  		     (let ((s (rcirc-short-buffer-name b)))
***************
*** 1366,1372 ****
  			     s
  			   (rcirc-facify s 'rcirc-mode-line-nick)))))
  		   rcirc-activity ",")
! 		  "]"))))
  
  (defun rcirc-short-buffer-name (buffer)
    "Return a short name for BUFFER to use in the modeline indicator."
--- 1365,1371 ----
  			     s
  			   (rcirc-facify s 'rcirc-mode-line-nick)))))
  		   rcirc-activity ",")
! 		  "]-"))))
  
  (defun rcirc-short-buffer-name (buffer)
    "Return a short name for BUFFER to use in the modeline indicator."

Re: rcirc bugfixes

[Miles Bader]

I've applied this patch.

-miles
-- 
We live, as we dream -- alone....