From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: isearch for doc-view.el Date: Wed, 07 Nov 2007 09:41:12 +0100 Message-ID: <87prymzbvb.fsf@baldur.tsdh.de> References: <7gk5p448xq.fsf@fencepost.gnu.org> <87wst33g0o.fsf@baldur.tsdh.de> <87pryv3eew.fsf@baldur.tsdh.de> <87k5p3qisa.fsf@baldur.tsdh.de> <87ejfbqdb4.fsf@baldur.tsdh.de> <87y7dhv89p.fsf@jurta.org> <87ejf8kxwg.fsf@baldur.tsdh.de> <87sl3koq9k.fsf_-_@baldur.tsdh.de> <87fxzk4dbd.fsf@baldur.tsdh.de> <877ikw4azt.fsf@baldur.tsdh.de> <87mytsz1ax.fsf@jurta.org> <87abprzspp.fsf@baldur.tsdh.de> <87k5ovqate.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194427018 7922 80.91.229.12 (7 Nov 2007 09:16:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2007 09:16:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 07 10:16:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iph1s-0006rK-OU for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 10:16:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iph1h-0005Xa-B1 for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 04:16:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iph1b-0005SC-K1 for emacs-devel@gnu.org; Wed, 07 Nov 2007 04:16:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iph1Z-0005Na-GC for emacs-devel@gnu.org; Wed, 07 Nov 2007 04:16:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iph1Z-0005NR-DV for emacs-devel@gnu.org; Wed, 07 Nov 2007 04:16:37 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Iph1Z-0002eY-1h for emacs-devel@gnu.org; Wed, 07 Nov 2007 04:16:37 -0500 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IpgTM-0007lg-I8 for emacs-devel@gnu.org; Wed, 07 Nov 2007 03:41:16 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 8B8CB45CB3 for ; Wed, 7 Nov 2007 03:41:15 -0500 (EST) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 07 Nov 2007 03:41:15 -0500 X-Sasl-enc: LVtA+mh6JFZwcIdZOWBGxBHUFyoRpfkRN2/au+JDhIfW 1194424874 Original-Received: from baldur.tsdh.de (dslb-084-063-044-082.pools.arcor-ip.net [84.63.44.82]) by mail.messagingengine.com (Postfix) with ESMTP id ACA2C10B20 for ; Wed, 7 Nov 2007 03:41:14 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <87k5ovqate.fsf@jurta.org> (Juri Linkov's message of "Wed, 07 Nov 2007 00:29:29 +0200") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82720 Archived-At: Juri Linkov writes: >>> Isearch on the plain text will provide enough cues to visually >>> locate the place of the found string on the rendered image. >> >> There are several problems with it: >> >> 1. The image scrolling commands only scroll on images, so you couldn't >> scroll down to the text with or C-n. >> >> The "Page 1 of 200" text isn't there anymore due to this. Now it's >> in the mode-line. (Thanks to Stefan) >> >> 2. My main problem with the search approach was that the real isearch >> happens in another buffer in the background and the doc-view buffer >> has to be updated accordingly by switching to the right page. With >> your approach that would be even harder. Here, you would have to >> do the same plus copying the page with the current match from the >> text representation's buffer to the doc-view buffer plus an >> additional isearch in the doc-view buffer to highlight the match. > > It seems the hardest problem here is fixing scrolling commands to take > into account the text below the image. Copying the text of the > current page and starting isearch on it should be easy. Feel free to give it a try. I'm don't know enough about the isearch internals to make it working in an acceptable amount of time, but I won't be against it if it feels good. I usability problem I see is that because of isearch the buffer is scrolled to the matching text and the user would have to scroll back to the image after every C-s. Basically I'm completely satisfied with the behavior I implemented in <87640fzs9o.fsf@baldur.tsdh.de>, but probably others are more demanding. > No, I meant displaying only one image and text from the same image at > once: > page1.png > page1 text > > But maybe for small documents (with small number of pages) displaying > all images at once is more preferable? I don't know if the benefits would be great enough to complicate the code. At least most navigation and search commends would need to be updated accordingly. If someone implements that and it works, it's fine with me, but I won't put it on my todo list for now. Bye, Tassilo