From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Subject: mb-depth.el (was: Minibuffer default values list) Date: Sun, 25 Nov 2007 17:19:52 +0200 Organization: JURTA Message-ID: <87prxyfkzn.fsf_-_@jurta.org> References: <87zlycuhrd.fsf@jurta.org> <87hckbecc0.fsf@jurta.org> <87prygxtot.fsf@jurta.org> <87hcjjkrgy.fsf@jurta.org> <87ir3u9r5s.fsf@jurta.org> <87myt3zk65.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196005052 6108 80.91.229.12 (25 Nov 2007 15:37:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2007 15:37:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 16:37:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IwJY9-0001A6-7z for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2007 16:37:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IwJXu-0006BB-6o for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2007 10:37:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IwJVU-0004pR-ME for emacs-devel@gnu.org; Sun, 25 Nov 2007 10:34:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IwJVS-0004np-2D for emacs-devel@gnu.org; Sun, 25 Nov 2007 10:34:50 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IwJVR-0004nm-Vt for emacs-devel@gnu.org; Sun, 25 Nov 2007 10:34:49 -0500 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IwJVK-0007Zs-MG; Sun, 25 Nov 2007 10:34:43 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1IwJVH-000N1A-Uc; Sun, 25 Nov 2007 17:34:40 +0200 In-Reply-To: (Richard Stallman's message of "Sat, 24 Nov 2007 22:43:13 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: 81fdb9d644701462f7849401ec726e21 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1827 [Nov 24 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 19 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84117 Archived-At: BTW, currently mb-depth.el uses 3 different name prefixes for its variables and functions: minibuffer-indicate-depth minibuffer-depth minibuf-depth To reduce the entropy, I propose to use the same name prefix `minibuffer-depth' that is the name of the primary function this package relies on: Index: lisp/mb-depth.el =================================================================== RCS file: /sources/emacs/emacs/lisp/mb-depth.el,v retrieving revision 1.4 diff -u -r1.4 mb-depth.el --- lisp/mb-depth.el 8 Oct 2007 14:44:49 -0000 1.4 +++ lisp/mb-depth.el 25 Nov 2007 15:19:45 -0000 @@ -24,7 +24,7 @@ ;;; Commentary: ;; -;; Defines the minor mode `minibuffer-indicate-depth-mode'. +;; Defines the minor mode `minibuffer-depth-indicate-mode'. ;; ;; When active, any recursive use of the minibuffer will show ;; the recursion depth in the minibuffer prompt. This is only @@ -32,7 +32,7 @@ ;;; Code: -(defvar minibuf-depth-indicator-function nil +(defvar minibuffer-depth-indicator-function nil "If non-nil, function to set up the minibuffer depth indicator. It is called with one argument, the minibuffer depth, and must return a string.") @@ -40,24 +40,24 @@ ;; An overlay covering the prompt. This is a buffer-local variable in ;; each affected minibuffer. ;; -(defvar minibuf-depth-overlay) -(make-variable-buffer-local 'minibuf-depth-overlay) +(defvar minibuffer-depth-overlay) +(make-variable-buffer-local 'minibuffer-depth-overlay) ;; This function goes on minibuffer-setup-hook -(defun minibuf-depth-setup-minibuffer () - "Set up a minibuffer for `minibuffer-indicate-depth-mode'. +(defun minibuffer-depth-setup () + "Set up a minibuffer for `minibuffer-depth-indicate-mode'. The prompt should already have been inserted." (when (> (minibuffer-depth) 1) - (setq minibuf-depth-overlay (make-overlay (point-min) (1+ (point-min)))) - (overlay-put minibuf-depth-overlay 'before-string - (if minibuf-depth-indicator-function - (funcall minibuf-depth-indicator-function (minibuffer-depth)) + (setq minibuffer-depth-overlay (make-overlay (point-min) (1+ (point-min)))) + (overlay-put minibuffer-depth-overlay 'before-string + (if minibuffer-depth-indicator-function + (funcall minibuffer-depth-indicator-function (minibuffer-depth)) (propertize (format "[%d]" (minibuffer-depth)) 'face 'highlight))) - (overlay-put minibuf-depth-overlay 'evaporate t))) + (overlay-put minibuffer-depth-overlay 'evaporate t))) ;;;###autoload -(define-minor-mode minibuffer-indicate-depth-mode - "Toggle Minibuffer Indicate Depth mode. +(define-minor-mode minibuffer-depth-indicate-mode + "Toggle Minibuffer Depth Indication mode. When active, any recursive use of the minibuffer will show the recursion depth in the minibuffer prompt. This is only useful if `enable-recursive-minibuffers' is non-nil. @@ -66,11 +66,11 @@ Returns non-nil if the new state is enabled." :global t :group 'minibuffer - (if minibuffer-indicate-depth-mode + (if minibuffer-depth-indicate-mode ;; Enable the mode - (add-hook 'minibuffer-setup-hook 'minibuf-depth-setup-minibuffer) + (add-hook 'minibuffer-setup-hook 'minibuffer-depth-setup) ;; Disable the mode - (remove-hook 'minibuffer-setup-hook 'minibuf-depth-setup-minibuffer))) + (remove-hook 'minibuffer-setup-hook 'minibuffer-depth-setup))) (provide 'mb-depth) -- Juri Linkov http://www.jurta.org/emacs/