all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning
Date: Thu, 13 Mar 2008 12:37:10 +0200	[thread overview]
Message-ID: <87prtyx63t.fsf@jurta.org> (raw)
In-Reply-To: <u1w6fjlt5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Mar 2008 06:21:42 +0200")

>> When testing Emacs 22 with `emacs -Q', I see that dired buffers are
>> almost unusable by default.  The red bold face for write permissions
>> is very distracting that prevents focusing on other parts of the dired
>> buffer.  I'm afraid Emacs users will hate us for this if we release
>> Emacs 22.2 with this annoyance.
>>
>> I propose a patch below for the 22 branch that renames the face
>> `dired-warn-writable' to more appropriate name `dired-perm-write'
>> that doesn't associate it with a warning, and changes its parent face
>> from `font-lock-warning-face' to `font-lock-comment-delimiter-face'
>> on non-Windows platforms.
>
> I object.  I think now is not the time for making behavioral changes
> in the release branch.  We are too close to the release.

This is not a behavioral change.  This is a fix for the grave usability bug
you introduced to GNU/Linux users.  It seems you realize the severity of
this problem since you wrote several times proposing to fix it:

> Date: Sun, 14 Oct 2007 06:10:33 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Then perhaps the new face dired-warn-writable that I introduced
> yesterday should inherit from `default' on _all_ platforms, not only
> on DOS/Windows.

and

> Date: Mon, 15 Oct 2007 00:20:45 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> It does fix that on platforms where group- and world-writable files
> are the default.  On other platforms, you can customize it, or we can
> make it inherit from `default' on _all_ platforms.

I think it is not yet too late to fix this bug because there is absolutely
no risk of breaking something else with this simple fix.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2008-03-13 10:37 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13 18:02 23.0.50; Middle ``w´´ in of permissions in dired-mode is red and bold: dired-warning Peter Dyballa
2007-10-13 18:22 ` 23.0.50; Middle ``wŽŽ " martin rudalics
2007-10-13 18:41   ` Peter Dyballa
2007-10-13 19:44     ` 23.0.50; Middle ``w▌▌ " Glenn Morris
2007-10-13 20:37     ` Re: 23.0.50; Middle ``wŽŽ " Eli Zaretskii
2007-10-13 21:30       ` Peter Dyballa
2007-10-13 23:24         ` Miles Bader
2007-10-14  4:10           ` Eli Zaretskii
2007-10-14  4:03         ` Eli Zaretskii
2007-10-14  5:40           ` Re: 23.0.50; Middle ``wZZ " Drew Adams
2007-10-14 20:24             ` Eli Zaretskii
2007-10-14 20:54               ` Drew Adams
2007-10-14 21:20                 ` Eli Zaretskii
2007-10-14 21:21               ` 23.0.50; Middle w " Juri Linkov
2007-10-14 22:20                 ` Eli Zaretskii
2008-03-13  2:19                   ` Juri Linkov
2008-03-13  4:21                     ` Eli Zaretskii
2008-03-13 10:37                       ` Juri Linkov [this message]
2008-03-13 20:16                         ` Eli Zaretskii
2008-03-14  1:07                           ` Juri Linkov
     [not found]                             ` <f7ccd24b0803140146m22e5305dy704d7415bc00f8cd@mail.gmail.com>
2008-03-14  8:48                               ` Juanma Barranquero
2008-03-14 21:30                                 ` Juri Linkov
2008-03-14 23:37                                   ` Juanma Barranquero
2008-03-15  0:17                                     ` Juri Linkov
2008-03-15  0:26                                       ` Juanma Barranquero
2008-03-14 12:12                             ` Eli Zaretskii
2008-03-14 22:45                     ` Chong Yidong
2008-03-15  0:16                       ` Juri Linkov
2008-03-15 14:27                         ` Eli Zaretskii
2008-03-15 16:20                           ` Juri Linkov
2008-03-15 18:30                             ` Eli Zaretskii
2008-03-15 14:10                       ` Eli Zaretskii
2008-03-15 16:20                         ` Juri Linkov
2008-03-15 20:44                           ` Stefan Monnier
2008-03-16 14:26                             ` martin rudalics
2008-03-16 16:29                             ` Juri Linkov
2007-10-15  0:49               ` 23.0.50; Middle ``wZZ " Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prtyx63t.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.