From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Faces applies to new frames
Date: Thu, 26 Jun 2008 22:43:12 -0400 [thread overview]
Message-ID: <87prq3k37j.fsf@stupidchicken.com> (raw)
In-Reply-To: <jwvd4m3fzd3.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 26 Jun 2008 21:28:48 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> AFAICT, the problem is that the default face is controlled by the `font'
>> frame parameter, but this is not saved to default-frame-alist by
>> internal-set-lisp-face-attribute. In comparison, the foreground-color
>
> I'm not convinced this is the root of the problem. For one, by default
> there is no `font' parameter in default-frame-alist, so as long as we
> leave it that way, it should not affect face settings. The code in
> face-set-after-frame-default should apply the defface-spec to every
> new frame, so we shouldn't need any entry in default-frame-alist for it
> to apply to new frames. The face-set-after-frame-default used to skip
> `default', so that was an important reason for the bug#47. I've fixed
> this part, but there are other weird things going on (I have some other
> weird problems here where X resources are obeyed even after I remove
> the calls to `make-face-x-resource-internal').
Maybe there's more than one bug here. When set-face-attribute is called
with a nil FRAME argument, that changes the face for all frames, and
this is done via frame parameters and not by changing the defface spec.
I don't think face-set-after-frame-default is even relevant to this
case.
From looking inside internal-set-lisp-face-attribute, it seems that the
face for future frames is changed by changing the frame parameters
`foreground', `background', etc. The `font' parameter is changed for
each existing frame (xfaces.c:3411), but nothing is saved in
default-frame-alist.
next prev parent reply other threads:[~2008-06-27 2:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 22:50 Faces applies to new frames Chong Yidong
2008-06-26 23:08 ` Miles Bader
2008-06-27 1:28 ` Stefan Monnier
2008-06-27 2:43 ` Chong Yidong [this message]
2008-06-27 6:18 ` Stefan Monnier
2008-06-27 17:32 ` Chong Yidong
2008-06-27 17:52 ` Stefan Monnier
2008-06-27 17:54 ` Chong Yidong
2008-06-27 10:48 ` Robert J. Chassell
2008-06-27 12:17 ` Robert J. Chassell
2008-06-28 16:01 ` Chong Yidong
2008-06-28 20:17 ` Stefan Monnier
2008-06-28 23:42 ` Chong Yidong
2008-06-29 3:14 ` Stefan Monnier
2008-06-29 3:42 ` Miles Bader
2008-06-29 4:22 ` Stefan Monnier
2008-06-29 4:43 ` Miles Bader
2008-06-29 4:47 ` Chong Yidong
2008-06-29 8:51 ` David Kastrup
2008-06-29 5:36 ` Stefan Monnier
2008-06-29 15:20 ` Richard M Stallman
2008-06-29 17:08 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 19:42 ` Stefan Monnier
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 4:30 ` Chong Yidong
2008-06-29 6:11 ` Stefan Monnier
2008-06-29 15:25 ` Chong Yidong
2008-06-29 18:00 ` Stefan Monnier
2008-06-29 19:24 ` Chong Yidong
2008-06-29 20:00 ` Stefan Monnier
2008-06-29 20:29 ` Chong Yidong
2008-06-30 0:58 ` Stefan Monnier
2008-06-30 2:24 ` Chong Yidong
2008-06-30 4:46 ` Stefan Monnier
2008-06-30 5:02 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 2:48 ` Chong Yidong
2008-06-29 3:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prq3k37j.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.