From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: visual-line-mode Date: Sat, 05 Jul 2008 14:41:25 -0400 Message-ID: <87prpsjhre.fsf@stupidchicken.com> References: <87zlp4raab.fsf@catnip.gol.com> <87d4lzehq2.fsf@stupidchicken.com> <87skuqbwr8.fsf@stupidchicken.com> <85E9BC5B-7337-4CD4-A783-6B2FAEBAEBCA@gmail.com> <87tzf6c5il.fsf@stupidchicken.com> <87abgxx0ju.fsf@stupidchicken.com> <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215301491 27796 80.91.229.12 (5 Jul 2008 23:44:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Jul 2008 23:44:51 +0000 (UTC) Cc: Emacs-Devel devel , "Lennart Borgman \(gmail\)" , Stefan Monnier , Miles Bader To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 06 01:45:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KFHRf-00036q-Se for ged-emacs-devel@m.gmane.org; Sun, 06 Jul 2008 01:45:36 +0200 Original-Received: from localhost ([127.0.0.1]:54133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFHQo-0004g3-NO for ged-emacs-devel@m.gmane.org; Sat, 05 Jul 2008 19:44:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFHQj-0004eV-NC for emacs-devel@gnu.org; Sat, 05 Jul 2008 19:44:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFHQh-0004Zg-72 for emacs-devel@gnu.org; Sat, 05 Jul 2008 19:44:36 -0400 Original-Received: from [199.232.76.173] (port=56546 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFHQh-0004ZX-4P for emacs-devel@gnu.org; Sat, 05 Jul 2008 19:44:35 -0400 Original-Received: from [18.115.7.218] (port=35094 helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KFHQc-0007GX-8u; Sat, 05 Jul 2008 19:44:30 -0400 Original-Received: by furry (Postfix, from userid 1000) id 85C7716DC02; Sat, 5 Jul 2008 14:41:25 -0400 (EDT) In-Reply-To: <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> (David Reitter's message of "Fri, 4 Jul 2008 16:04:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Greylist: delayed 18185 seconds by postgrey-1.27 at monty-python; Sat, 05 Jul 2008 19:44:30 EDT X-Greylist: delayed 18184 seconds by postgrey-1.27 at monty-python; Sat, 05 Jul 2008 19:44:30 EDT X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100376 Archived-At: David Reitter writes: > OK, this works fine now. Good, I've checked it in (together with a couple other minor fixes). > The visual-line minor mode is attached again for people to try out > once you've committed your patch. Visual-line-mode works fine for me > with your patches (on 22). > > Note that this minor mode works correctly works with variable width > fonts. If we had a way to determine the buffer position for given > pixel coordinates (something like posn-point, without requiring the > event structure that contains the information), then I could improve > this package further. One thing that's not clear to me is whether your minor mode correctly handles invisible/intangible text and point motion hooks. One of the reasons line-move-1 and line-move-finish is so complicated is, unfortunately, the need to DTRT for these. I don't see anything analogous in your code; am I missing something?