From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: visual-line-mode Date: Thu, 10 Jul 2008 19:35:37 -0400 Message-ID: <87prplfh2u.fsf@stupidchicken.com> References: <87zlp4raab.fsf@catnip.gol.com> <87d4lzehq2.fsf@stupidchicken.com> <87skuqbwr8.fsf@stupidchicken.com> <85E9BC5B-7337-4CD4-A783-6B2FAEBAEBCA@gmail.com> <87tzf6c5il.fsf@stupidchicken.com> <87abgxx0ju.fsf@stupidchicken.com> <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> <87prpsjhre.fsf@stupidchicken.com> <375C0006-2B47-4B1F-9EB2-ED47941C2DB3@gmail.com> <87od56tp4o.fsf@stupidchicken.com> <71C2D50C-1680-4ADD-A7E3-7B7A1146B85D@gmail.com> <87ej61n19h.fsf@stupidchicken.com> <87k5ftqqev.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215732941 28969 80.91.229.12 (10 Jul 2008 23:35:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jul 2008 23:35:41 +0000 (UTC) Cc: David Reitter , "Lennart Borgman \(gmail\)" , Stefan Monnier , Emacs-Devel devel To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 11 01:36:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KH5gZ-0000DJ-0f for ged-emacs-devel@m.gmane.org; Fri, 11 Jul 2008 01:36:27 +0200 Original-Received: from localhost ([127.0.0.1]:34154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KH5fg-0007dy-QH for ged-emacs-devel@m.gmane.org; Thu, 10 Jul 2008 19:35:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KH5fc-0007dl-H5 for emacs-devel@gnu.org; Thu, 10 Jul 2008 19:35:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KH5fa-0007dG-2L for emacs-devel@gnu.org; Thu, 10 Jul 2008 19:35:27 -0400 Original-Received: from [199.232.76.173] (port=34594 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KH5fZ-0007dD-Sn for emacs-devel@gnu.org; Thu, 10 Jul 2008 19:35:25 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:43600 helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KH5fV-0005mz-Dx; Thu, 10 Jul 2008 19:35:21 -0400 Original-Received: by cyd (Postfix, from userid 1000) id 9055A57E2C8; Thu, 10 Jul 2008 19:35:37 -0400 (EDT) In-Reply-To: <87k5ftqqev.fsf@catnip.gol.com> (Miles Bader's message of "Fri, 11 Jul 2008 08:18:32 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100560 Archived-At: Miles Bader writes: > David Reitter writes: >>> Could someone explain the difference between visual-line-mode and the >>> short patch that Stefan posted? >> >> Apart from the issues pointed out by Miles, I believe that Stefan's >> patch does not support variable width fonts. (Could someone who can >> run 23 try this?) > > No, it works fine with variable-width fonts. Aha, so it does. I think the docstring for vertical-motion in Emacs 23 is misleading: the new (COL . LINES) argument specifies a pixel position, computed using the default column-width, rather than character columns. This should probably be noted. So Stefan's basic approach to line-move is probably what we want to use for Emacs 23. Still, I think the correct approach is to merge in the minor mode, then change it to use the new vertical-motion feature.