From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: line-line-move-visual: was line motion problem Date: Mon, 21 Jul 2008 12:01:51 -0400 Message-ID: <87prp78bv4.fsf@stupidchicken.com> References: <18557.63556.231489.523637@gargle.gargle.HOWL> <5F62534C-D5CE-4364-8F73-E1AE0D61B4E2@gmail.com> <87abghlqs2.fsf@stupidchicken.com> <87hcap3ct7.fsf@stupidchicken.com> <87mykg84aj.fsf@stupidchicken.com> <200807181530.m6IFUHVp029662@sallyv1.ics.uci.edu> <06ED973A-F762-4586-9913-37B3622C8644@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216656394 6887 80.91.229.12 (21 Jul 2008 16:06:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jul 2008 16:06:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 21 18:07:22 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KKxuy-0006ib-Vb for ged-emacs-devel@m.gmane.org; Mon, 21 Jul 2008 18:07:21 +0200 Original-Received: from localhost ([127.0.0.1]:41772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKxu5-0002Gw-Rc for ged-emacs-devel@m.gmane.org; Mon, 21 Jul 2008 12:06:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKxoa-0006Uc-OJ for emacs-devel@gnu.org; Mon, 21 Jul 2008 12:00:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKxoX-0006Tg-2l for emacs-devel@gnu.org; Mon, 21 Jul 2008 12:00:43 -0400 Original-Received: from [199.232.76.173] (port=35000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKxoW-0006TU-J0 for emacs-devel@gnu.org; Mon, 21 Jul 2008 12:00:40 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:51944 helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKxoV-0006UR-LV for emacs-devel@gnu.org; Mon, 21 Jul 2008 12:00:40 -0400 Original-Received: by cyd (Postfix, from userid 1000) id 8464A57E32A; Mon, 21 Jul 2008 12:01:51 -0400 (EDT) In-Reply-To: <06ED973A-F762-4586-9913-37B3622C8644@gmail.com> (David Reitter's message of "Mon, 21 Jul 2008 11:49:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101089 Archived-At: David Reitter writes: > OK, there is still the paragraph marking function. The following two > major items (and some smaller issues) have been addressed: Please don't add a menu-bar entry for this. The menu-bar is already too cluttered. Also, I'd suggest a couple of tweaks to your docstrings: > + "Face used to visualize NEWLINE char mapping. > + > + See `blank-display-mappings'." Don't capitalize "newline". > + (defvar show-newlines-newline-code > + (vector (make-glyph-code 182 'blank-newline) 10)) Add a brief docstring for this. > + (define-minor-mode show-newlines-mode > + "Mark newlines in current buffer" This should also say something like "Newlines are marked using the glyph specified by `show-newlines-newline-code'." If no one objects within the next 2 days, go ahead and check your code in, with the above docstring fixes and without the menu-bar entry. You'll also need a proper ChangeLog entry and a brief entry in etc/NEWS.