From: Chong Yidong <cyd@stupidchicken.com>
To: David Reitter <david.reitter@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: line-line-move-visual: was line motion problem
Date: Mon, 21 Jul 2008 12:01:51 -0400 [thread overview]
Message-ID: <87prp78bv4.fsf@stupidchicken.com> (raw)
In-Reply-To: <06ED973A-F762-4586-9913-37B3622C8644@gmail.com> (David Reitter's message of "Mon, 21 Jul 2008 11:49:52 -0400")
David Reitter <david.reitter@gmail.com> writes:
> OK, there is still the paragraph marking function. The following two
> major items (and some smaller issues) have been addressed:
Please don't add a menu-bar entry for this. The menu-bar is already too
cluttered.
Also, I'd suggest a couple of tweaks to your docstrings:
> + "Face used to visualize NEWLINE char mapping.
> +
> + See `blank-display-mappings'."
Don't capitalize "newline".
> + (defvar show-newlines-newline-code
> + (vector (make-glyph-code 182 'blank-newline) 10))
Add a brief docstring for this.
> + (define-minor-mode show-newlines-mode
> + "Mark newlines in current buffer"
This should also say something like "Newlines are marked using the glyph
specified by `show-newlines-newline-code'."
If no one objects within the next 2 days, go ahead and check your code
in, with the above docstring fixes and without the menu-bar entry.
You'll also need a proper ChangeLog entry and a brief entry in etc/NEWS.
next prev parent reply other threads:[~2008-07-21 16:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 13:31 line-line-move-visual: was line motion problem T. V. Raman
2008-07-16 16:26 ` Stefan Monnier
2008-07-16 16:37 ` David Reitter
2008-07-16 16:47 ` Chong Yidong
2008-07-16 18:26 ` Chong Yidong
2008-07-17 23:44 ` Chong Yidong
2008-07-18 4:35 ` Miles Bader
2008-07-18 14:16 ` Stefan Monnier
2008-07-18 14:24 ` David Reitter
2008-07-18 15:21 ` Stefan Monnier
2008-07-18 15:30 ` Dan Nicolaescu
2008-07-18 15:50 ` Stefan Monnier
2008-07-19 0:10 ` Miles Bader
2008-07-21 15:49 ` David Reitter
2008-07-21 16:01 ` Chong Yidong [this message]
2008-07-21 17:31 ` Miles Bader
2008-07-21 19:24 ` Stefan Monnier
2008-07-21 20:18 ` Miles Bader
2008-07-21 17:36 ` David Reitter
2008-07-21 16:09 ` Dan Nicolaescu
2008-07-21 17:30 ` David Reitter
2008-07-21 17:33 ` David Reitter
2008-07-21 23:05 ` Vinicius Jose Latorre
2008-07-22 1:31 ` Chong Yidong
2008-07-22 1:58 ` Vinicius Jose Latorre
2008-07-22 2:20 ` David Reitter
2008-07-23 1:53 ` Vinicius Jose Latorre
2008-07-23 2:53 ` David Reitter
2008-07-23 3:19 ` Vinicius Jose Latorre
2008-07-23 10:58 ` David Reitter
2008-07-24 3:37 ` Vinicius Jose Latorre
[not found] ` <9B9CE742-E040-4484-9BDC-593DE5B6B037@gmail.com>
2008-07-26 0:15 ` Vinicius Jose Latorre
2008-07-26 0:32 ` Drew Adams
2008-07-26 2:11 ` Vinicius Jose Latorre
2008-07-26 2:39 ` Drew Adams
2008-07-26 13:46 ` Vinicius Jose Latorre
2008-07-26 10:44 ` David Reitter
2008-07-26 12:59 ` Vinicius Jose Latorre
2008-07-25 13:41 ` T. V. Raman
2008-07-18 21:07 ` David Reitter
2008-07-18 22:57 ` Jason Rumney
2008-07-18 16:08 ` Chong Yidong
2008-07-18 18:36 ` Stefan Monnier
2008-07-20 3:34 ` Chong Yidong
2008-07-20 3:43 ` Chong Yidong
2008-07-20 4:15 ` Miles Bader
2008-07-21 4:09 ` Chong Yidong
2008-07-28 13:45 ` Juri Linkov
2008-07-28 14:11 ` Miles Bader
2008-07-28 14:35 ` Juri Linkov
2008-07-28 14:12 ` Chong Yidong
2008-07-25 13:39 ` T. V. Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prp78bv4.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.