From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#591: 23.0.60; lisp-complete-symbol erases extra text Date: Wed, 30 Jul 2008 00:36:59 -0400 Message-ID: <87prowc7is.fsf@stupidchicken.com> References: <87ej5czaef.fsf@stupidchicken.com> Reply-To: Chong Yidong , 591@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217393264 15231 80.91.229.12 (30 Jul 2008 04:47:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Jul 2008 04:47:44 +0000 (UTC) Cc: 591@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 30 06:48:33 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KO3c1-0001yO-9Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2008 06:48:33 +0200 Original-Received: from localhost ([127.0.0.1]:51086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KO3b7-0004qM-1w for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2008 00:47:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KO3az-0004oJ-Mw for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 00:47:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KO3av-0004ku-Uo for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 00:47:28 -0400 Original-Received: from [199.232.76.173] (port=42455 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KO3av-0004kc-E5 for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 00:47:25 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42294) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KO3au-0007lj-Mq for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 00:47:25 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6U4lK1X005903; Tue, 29 Jul 2008 21:47:21 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m6U4j4lA004819; Tue, 29 Jul 2008 21:45:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 30 Jul 2008 04:45:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 591 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 591-submit@emacsbugs.donarmstrong.com id=B591.12173926333394 (code B ref 591); Wed, 30 Jul 2008 04:45:04 +0000 Original-Received: (at 591) by emacsbugs.donarmstrong.com; 30 Jul 2008 04:37:13 +0000 Original-Received: from furry (c-24-63-201-57.hsd1.ma.comcast.net [24.63.201.57]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6U4bA1G003388 for <591@emacsbugs.donarmstrong.com>; Tue, 29 Jul 2008 21:37:11 -0700 Original-Received: by furry (Postfix, from userid 1000) id EA4DDC055; Wed, 30 Jul 2008 00:36:59 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Tue, 29 Jul 2008 18:07:57 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Wed, 30 Jul 2008 00:47:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18919 Archived-At: Stefan Monnier writes: >> This sets completion-base-size to 0, which causes the completions buffer >> to delete everything in the Lisp buffer when you make a selection. > > The problem is that leaving it nil will revert to the use of > a heuristic. Fixing it right is a bit more difficult. I don't understand what you mean :-P >> I don't understand why we need the (completely undocumented) hack >> introduced here, where the cdr of the last item on the completions list >> gives completion-base-size. Does anything else in Emacs depend on this? >> Why not simply add a new optional argument to display-completion-list? > > Yes the base-size in the cdr is a hack, and we be able to get rid of it > now that I've added the new `boundaries' action. But passing it as an > additional argument won't make any difference for the bug at hand. Why not? That would allow lisp-complete-symbol to pass the correct value of completion-base-size, which it has already computed (i.e. the variable `beg' in lisp-complete-symbol) to display-completion-list. No?