From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Virtual Info files and nodes Date: Mon, 29 Jun 2009 03:48:21 +0300 Organization: JURTA Message-ID: <87prcnhn4i.fsf@mail.jurta.org> References: <87ws6wnj3s.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246237329 17229 80.91.229.12 (29 Jun 2009 01:02:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2009 01:02:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 29 03:02:02 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ML5Fw-0006QN-Qv for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 03:02:01 +0200 Original-Received: from localhost ([127.0.0.1]:56284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ML5Fv-0008I8-TV for ged-emacs-devel@m.gmane.org; Sun, 28 Jun 2009 21:01:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ML5Fr-0008I3-9m for emacs-devel@gnu.org; Sun, 28 Jun 2009 21:01:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ML5Fm-0008Gt-Ua for emacs-devel@gnu.org; Sun, 28 Jun 2009 21:01:55 -0400 Original-Received: from [199.232.76.173] (port=47062 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ML5Fm-0008Gm-NI for emacs-devel@gnu.org; Sun, 28 Jun 2009 21:01:50 -0400 Original-Received: from smtp-out3.starman.ee ([85.253.0.5]:44855 helo=smtp-gw1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ML5Fm-0006T1-4t for emacs-devel@gnu.org; Sun, 28 Jun 2009 21:01:50 -0400 Original-Received: from mx1.starman.ee (mx1.starman.ee [62.65.192.16]) by smtp-gw1.starman.ee (Postfix) with ESMTP id EBDA0A214C7; Mon, 29 Jun 2009 04:01:48 +0300 (EEST) X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.55.251.cable.starman.ee [82.131.55.251]) by mx1.starman.ee (Postfix) with ESMTP id 013493F4063; Mon, 29 Jun 2009 04:01:42 +0300 (EEST) In-Reply-To: (Stefan Monnier's message of "Mon, 29 Jun 2009 02:14:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111799 Archived-At: > It looks fairly good. I have a few comments/questions: > - Can't it be pushed a bit further to make it handle the "dir" special > case as well? Hmm, I haven't thought about "dir" because "dir" is a very old case, but why not - it is just one call to `Info-insert-dir' and the last special case is gone. Will do this in the next version of the patch. > - Why regexps for filenames? This is a forethought for possible future cases. But maybe only strings should be allowed now, and regexps can be added only when necessary. > - Why ^...$ when you really mean \`...\'? Ok, will fix this. > - Why check (stringp filename) in Info-virtual-file? Isn't it an > error to call it with something else than a string. Really only nil can be expected now, but `stringp' is a precaution against t (the current internal value for "dir" ) and former symbol values `apropos', `toc' (maybe some external packages still use them). > - Why have separate Info-virtual-file and Info-virtual-node functions? > (the latter is only called (once) from Info-virtual-fun, and the former > is called once from Info-virtual-fun and another time where it seems > that Info-virtual-fun could be used in its stead). Info-virtual-fun expects an argument `op' for an operation type, but these places call (Info-virtual-file file) with only a file name argument to check whether a file name is virtual (if its name is defined in a list of definitions of virtual Info files). -- Juri Linkov http://www.jurta.org/emacs/