From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Virtual Info files and nodes
Date: Mon, 29 Jun 2009 03:48:21 +0300 [thread overview]
Message-ID: <87prcnhn4i.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvljnbvr7c.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 29 Jun 2009 02:14:19 +0200")
> It looks fairly good. I have a few comments/questions:
> - Can't it be pushed a bit further to make it handle the "dir" special
> case as well?
Hmm, I haven't thought about "dir" because "dir" is a very old case,
but why not - it is just one call to `Info-insert-dir' and the last
special case is gone. Will do this in the next version of the patch.
> - Why regexps for filenames?
This is a forethought for possible future cases. But maybe only strings
should be allowed now, and regexps can be added only when necessary.
> - Why ^...$ when you really mean \`...\'?
Ok, will fix this.
> - Why check (stringp filename) in Info-virtual-file? Isn't it an
> error to call it with something else than a string.
Really only nil can be expected now, but `stringp' is a precaution
against t (the current internal value for "dir" ) and former symbol
values `apropos', `toc' (maybe some external packages still use them).
> - Why have separate Info-virtual-file and Info-virtual-node functions?
> (the latter is only called (once) from Info-virtual-fun, and the former
> is called once from Info-virtual-fun and another time where it seems
> that Info-virtual-fun could be used in its stead).
Info-virtual-fun expects an argument `op' for an operation type,
but these places call (Info-virtual-file file) with only a file name
argument to check whether a file name is virtual (if its name is defined
in a list of definitions of virtual Info files).
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-06-29 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 21:28 Virtual Info files and nodes Juri Linkov
2009-06-29 0:14 ` Stefan Monnier
2009-06-29 0:48 ` Juri Linkov [this message]
2009-06-29 8:42 ` Stefan Monnier
2009-06-29 23:55 ` Juri Linkov
[not found] ` <jwvr5x11odl.fsf-monnier+emacs@gnu.org>
2009-07-01 0:01 ` Juri Linkov
2009-07-01 15:02 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prcnhn4i.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.