From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Comments on misearch.el Date: Tue, 17 Nov 2009 19:54:46 +0200 Organization: JURTA Message-ID: <87pr7h2go1.fsf@mail.jurta.org> References: <87iqd9mb0u.fsf@freebits.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258480987 23442 80.91.229.12 (17 Nov 2009 18:03:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2009 18:03:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Tobias C. Rittweiler" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 17 19:02:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NASOE-0002bn-O5 for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2009 19:02:55 +0100 Original-Received: from localhost ([127.0.0.1]:51036 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NASOE-0005Tw-EE for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2009 13:02:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NASKk-0003A3-23 for emacs-devel@gnu.org; Tue, 17 Nov 2009 12:59:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NASKf-00036R-AL for emacs-devel@gnu.org; Tue, 17 Nov 2009 12:59:17 -0500 Original-Received: from [199.232.76.173] (port=53333 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NASKe-000362-OD for emacs-devel@gnu.org; Tue, 17 Nov 2009 12:59:13 -0500 Original-Received: from smtp-out1.starman.ee ([85.253.0.3]:38794 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NASKe-0007Kf-4i for emacs-devel@gnu.org; Tue, 17 Nov 2009 12:59:12 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.30.92.cable.starman.ee [82.131.30.92]) by mx1.starman.ee (Postfix) with ESMTP id 097DA3F4152; Tue, 17 Nov 2009 19:59:05 +0200 (EET) In-Reply-To: <87iqd9mb0u.fsf@freebits.de> (Tobias C. Rittweiler's message of "Tue, 17 Nov 2009 16:22:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117114 Archived-At: Thank you for your feedback. Feel free to post bug reports about misearch.el to emacs-pretest-bug@gnu.org if you want to track the bug fixing progress ;-) > I just tried misearch.el which provides the ability to search through > multiple files / buffers via isearch. Thank you, Juri, for writing it, > it's exactly what I need. > > (BTW., is there something like misearch but for query-replace, too?) Yes, there is also multi-file query-replace. It can be started from Dired by marking files and typing `Q'. > I do have some comments on it: > > * The docstring of `multi-isearch-next-buffer-function' says that the > function is called with the current buffer as first argument. > > However, in case of the initial buffer, it's actually called with > `nil' as first argument. > > Is that intended? If so, the docstring should reflect that. > I now have in my next-buffer function > > (setq current-buffer (or current-buffer (current-buffer))) > > as a workaround. Yes, this should be easy to fix. I will do that. > * It'd be nice, not only to display "Repeat for next buffer", but > actually include the next buffer's name. Good idea! I'll try to implement this. > * If I'm in a file that contains matches, and I'm at the last match, > it exhibits the following behaviour in the minibuffer: > > Multi Isearch: ... (pressing C-s) > > Failing multi Isearch: ... [Repeat ...] (pressing C-s) > > jumps to first match in next buffer > > However, if I'm in a buffer that won't have a match, I see the > following behaviour: > > Multi Isearch: ..(incremently typing).. --> turns to > Failing multi Isearch: ... [Repeat ...] (pressing C-s) > > Failing mutli Isearch: ... (pressing C-s) > > goes to next file > > I.e., as you can hopefully see, it expects one C-s too much. (The > line without the "[Repeat ...]" is superfluous.) Could you please try with different values of `multi-isearch-pause'. You can customize it to: "Don't pause", "Only in initial buffer" or "All buffers". -- Juri Linkov http://www.jurta.org/emacs/