From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs/lisp ChangeLog vc-bzr.el
Date: Mon, 07 Dec 2009 00:12:08 +0100 [thread overview]
Message-ID: <87pr6rwvcn.fsf@telefonica.net> (raw)
In-Reply-To: <E1NHNcZ-0005Lr-Ph@cvs.savannah.gnu.org> (Chong Yidong's message of "Sun, 06 Dec 2009 20:22:19 +0000")
> CVSROOT: /sources/emacs
> Module name: emacs
> Changes by: Chong Yidong <cyd> 09/12/06 20:22:19
>
> Modified files:
> lisp : ChangeLog vc-bzr.el
>
[snip]
> Index: vc-bzr.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/vc-bzr.el,v
> retrieving revision 1.89
> retrieving revision 1.90
> diff -u -b -r1.89 -r1.90
> --- vc-bzr.el 3 Dec 2009 08:53:06 -0000 1.89
> +++ vc-bzr.el 6 Dec 2009 20:22:19 -0000 1.90
> @@ -572,8 +572,12 @@
> (inhibit-read-only t))
> (setq string (substring string (match-end 0)))
> (unless tag
> - (setq tag (propertize rev 'help-echo (concat "Author: " author
> - ", date: " date)
> + (setq tag
> + (propertize
> + (concat rev " " (substring author 0 7))
> + 'help-echo (format "Revision: %d, author: %s, date: %s"
> + (string-to-number rev)
> + author date)
> 'mouse-face 'highlight))
> (puthash key tag table))
> (goto-char (process-mark proc))
That change fails on (substring author 0 7) when `author' contains less
than 7 characters:
error in process filter: concat: Args out of range: "oscar", 0, 7
error in process filter: Args out of range: "oscar", 0, 7
I tried with a kludge:
(substring (concat author " ") 0 7)
and that fixed the problem.
I tried this variation too:
(substring author 0 (min 7 (length author)))
but the result is not so pretty, as the "author" column has no fixed
width anymore.
--
Óscar
next parent reply other threads:[~2009-12-06 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NHNcZ-0005Lr-Ph@cvs.savannah.gnu.org>
2009-12-06 23:12 ` Óscar Fuentes [this message]
2009-12-06 23:27 ` emacs/lisp ChangeLog vc-bzr.el Chong Yidong
2009-12-07 7:01 ` David Kastrup
2009-12-07 16:18 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr6rwvcn.fsf@telefonica.net \
--to=ofv@wanadoo.es \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.