all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Fix info display of images
Date: Sun, 13 Dec 2009 20:31:35 +0200	[thread overview]
Message-ID: <87pr6iskww.fsf@mail.jurta.org> (raw)
In-Reply-To: <87aaxnjfkg.fsf@lola.goethe.zz> (David Kastrup's message of "Sun,  13 Dec 2009 12:09:35 +0100")

> Since there does not appear to be interest to apply this patch, let me
> illustrate the difference using two screen shots, the first without the
> patch, the second with the patch.

Thanks, it's clear now what is the reason of this bug.

`Info-hide-cookies-node' hides a cookie, including one optional
*trailing newline*.

The image cookies in Lilypond's Cheat sheet end with trailing newlines,
so when `Info-hide-cookies-node' hides the newline, images are displayed
in one long line.

It seems hiding the newline was necessary only for index cookies,
that after hiding would leave an empty line.

OTOH, the docstring of `Info-hide-cookies-node' says:

  Hide unrecognized cookies in current node.

So your patch uses `(not (get-text-property start 'display))' to tell
`Info-hide-cookies-node' that this cookie was already recognized and
processed by `Info-display-images-node'.

> I think that the improvement is rather obvious.

This is not just improvement, but a plain bug fix.  I suggest to install it.

Since IIUC currently CVS is read-only, you could create a bug report in
the bug database to guarantee your bug fix is not lost and fixed in the
next release.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2009-12-13 18:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05 23:48 Fix info display of images David Kastrup
2009-12-07 17:55 ` Juri Linkov
2009-12-07 20:28   ` David Kastrup
2009-12-13 11:09     ` David Kastrup
2009-12-13 18:31       ` Juri Linkov [this message]
2009-12-14  4:16         ` Chong Yidong
2009-12-14  5:14           ` Ediff-patch-file with wrong default buffer (was: Fix info display of images) Juri Linkov
2009-12-14  5:43             ` Michael Kifer
2009-12-14  5:47               ` Ediff-patch-file with wrong default buffer Juri Linkov
2009-12-14  6:15                 ` Michael Kifer
2009-12-14  6:54                   ` Juri Linkov
2010-02-02  0:31                     ` Juri Linkov
2010-02-02  2:34                       ` Stefan Monnier
2010-02-02 22:38                         ` Juri Linkov
2010-02-02  0:33                     ` Juri Linkov
2009-12-14  9:35                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pr6iskww.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.