From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: Commit netiquette.
Date: Thu, 18 Feb 2010 16:40:13 +0100 [thread overview]
Message-ID: <87pr42y2le.fsf@telefonica.net> (raw)
In-Reply-To: E1Ni7dY-0005p4-Ew@fencepost.gnu.org
"Alfred M. Szmidt" <ams@gnu.org> writes:
> The Committer used the full Changelog entry as the commit message, so on
> interfaces that just shows the first line of the commit (like the
> emacs-diffs mailing list or the output of `bzr log --short' or `qlog')
> you see
>
> 2010-02-17 Mark A. Hershberger <mah@everybody.org>
>
> which is hardly indicative of the change.
>
> This seems more of a short comming in `bzr log --short' than in the
> way one writes commit messages. A commit message is more than a
> single line.
This is like saying that "Subject" fields on e-mail messages are of
little use, that one always ought to look at the body of the message
before deciding if it is an interesting one.
> And the purpose of a change is always more suitable in the actual
> code as a comment.
Sure, but describing the purpose on the commit message is useful too,
mostly when the change is not circumscribed to a single point on one
file. Very handy for using with `annotate'.
On this respect I find changelog entries as a lame way of documenting
changes. Most of the time a changelog does not give more information
than what I quickly get combining `log' and `annotate', except when the
changelog entry documents the purpose of the change (not only *what*
changed) but this rarely happens. On projects that extensively use the
commit messages for documenting changes, using `log' and `annotate' is a
great learning tool when you are getting familiar with the code base.
next prev parent reply other threads:[~2010-02-18 15:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 23:44 Commit netiquette Óscar Fuentes
2010-02-18 0:27 ` Glenn Morris
2010-02-18 0:51 ` Óscar Fuentes
2010-02-18 5:35 ` Glenn Morris
2010-02-18 7:13 ` Chong Yidong
2010-02-18 15:11 ` Mark A. Hershberger
2010-02-18 14:45 ` Alfred M. Szmidt
2010-02-18 15:12 ` Juanma Barranquero
2010-02-18 16:14 ` Stefan Monnier
2010-02-19 3:42 ` David Reitter
2010-02-19 5:32 ` Stefan Monnier
2010-02-19 8:17 ` Alfred M. Szmidt
2010-02-19 18:19 ` Stefan Monnier
2010-02-20 11:02 ` Chong Yidong
2010-02-20 11:06 ` Chong Yidong
2010-02-23 19:25 ` Alfred M. Szmidt
2010-02-19 8:17 ` Alfred M. Szmidt
2010-02-19 8:39 ` Juanma Barranquero
2010-02-20 12:37 ` Alfred M. Szmidt
2010-02-20 14:13 ` Miles Bader
2010-02-20 14:23 ` Eli Zaretskii
2010-02-22 2:17 ` Miles Bader
2010-02-22 4:14 ` Eli Zaretskii
2010-02-23 16:37 ` Stefan Monnier
2010-02-23 19:25 ` Alfred M. Szmidt
2010-02-20 18:55 ` Juanma Barranquero
2010-02-23 19:25 ` Alfred M. Szmidt
2010-02-23 20:28 ` Juanma Barranquero
2010-02-23 22:09 ` David Kastrup
2010-02-23 22:57 ` Juanma Barranquero
2010-02-18 15:40 ` Óscar Fuentes [this message]
2010-02-19 0:22 ` Stephen J. Turnbull
2010-02-19 7:53 ` Miles Bader
2010-02-18 15:15 ` Mark A. Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr42y2le.fsf@telefonica.net \
--to=ofv@wanadoo.es \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.