From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#6674: [PATCH fixed] bug#6674: fix assignment of grep-find-use-xargs on Windows/MS-DOS Date: Mon, 02 Aug 2010 22:15:02 +0200 Message-ID: <87pqy0bwl5.fsf@telefonica.net> References: <878w564xtc.fsf@telefonica.net> <87vd8a2rxg.fsf@telefonica.net> <87r5iy2ptw.fsf@telefonica.net> <83vd8acbbv.fsf@gnu.org> <87eiey2apg.fsf@telefonica.net> <4C569D60.5040804@gmail.com> <8739uxdnib.fsf_-_@telefonica.net> <87vd7sdhxu.fsf_-_@telefonica.net> <831vagzvcp.fsf@gnu.org> <8739uwdbz7.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1280781513 531 80.91.229.12 (2 Aug 2010 20:38:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 Aug 2010 20:38:33 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 02 22:38:32 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Og1mJ-0001ag-Lv for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Aug 2010 22:38:32 +0200 Original-Received: from localhost ([127.0.0.1]:43058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Og1mI-0006hK-Rv for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Aug 2010 16:38:30 -0400 Original-Received: from [140.186.70.92] (port=60742 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Og1lv-0006WA-KQ for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Og1lu-000323-MG for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:38:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52939) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Og1lu-00031w-JG for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:38:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Og1Pa-0000qu-Qq; Mon, 02 Aug 2010 16:15:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878w564xtc.fsf@telefonica.net> Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Aug 2010 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6674 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.12807800953261 (code B ref -1); Mon, 02 Aug 2010 20:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Aug 2010 20:14:55 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Og1PT-0000qY-67 for submit@debbugs.gnu.org; Mon, 02 Aug 2010 16:14:55 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Og1PQ-0000qS-Uf for submit@debbugs.gnu.org; Mon, 02 Aug 2010 16:14:53 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:55986) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Og1Pp-0000DB-1z for submit@debbugs.gnu.org; Mon, 02 Aug 2010 16:15:17 -0400 Original-Received: from [140.186.70.92] (port=49607 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Og1Pn-0004sm-9z for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:15:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Og1Pm-0006xt-FY for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:15:15 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36756) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Og1Pm-0006xK-8z for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 16:15:14 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Og1Pj-00064U-Gt for bug-gnu-emacs@gnu.org; Mon, 02 Aug 2010 22:15:11 +0200 Original-Received: from 83.42.13.171 ([83.42.13.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Aug 2010 22:15:11 +0200 Original-Received: from ofv by 83.42.13.171 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Aug 2010 22:15:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 83.42.13.171 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:R0S4DnXX1H9X5mNG2Zx/1MJJZZw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 02 Aug 2010 16:15:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39172 Archived-At: Óscar Fuentes writes: >>> * cmdproxy.c (main): use _snprintf instead of wsprintf. Fixes >>> bug#6647. wsprintf has a 1024 char limit on Windows. >> >> Thanks. >> >> wsprintf supports wide character (UTF-16) strings, whereas _snprintf >> does not. > > wsprintf supports UTF-16 iff the application is compiled with Unicode > support on. cmdproxy uses char, not wchar_t, so if the build switches on > Unicode the compilation will fail. This is poorly explained. To begin, cmdproxy, as it was before the patch, does not support UTF-16. For fixing that, you need to start by implementing int wmain(int argc, wchar_t *argv[]) and revise all string handling from there. The workload the patch adds for migrating cmdproxy to UTF-16 would consist on s/_snprintf/_snwprintf. Not doing that would cause compilation errors. [snip]