From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6956: 24.0.50; pasting mouse selection in other session pastes only first word Date: Sat, 04 Sep 2010 21:53:46 -0400 Message-ID: <87pqwtuf9x.fsf@stupidchicken.com> References: <296F488C207B496D9CA42F4AA0F7C835@us.oracle.com> <83eidek812.fsf@gnu.org> <87eideejlh.fsf@stupidchicken.com> <838w3ljzq0.fsf@gnu.org> <83bp8eht8b.fsf@gnu.org> <4C8204D6.5020201@swipnet.se> <8339tpix6o.fsf@gnu.org> <87hbi58gxc.fsf@stupidchicken.com> <4C82AD90.5040003@harpegolden.net> <4C82BC4E.4080500@harpegolden.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1283652616 2431 80.91.229.12 (5 Sep 2010 02:10:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 5 Sep 2010 02:10:16 +0000 (UTC) Cc: 6956@debbugs.gnu.org, Dj@debbugs.gnu.org To: David De La Harpe Golden Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 05 04:10:14 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Os4gL-0000gU-Rt for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Sep 2010 04:10:10 +0200 Original-Received: from localhost ([127.0.0.1]:49085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Os4gK-0006ZV-RT for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Sep 2010 22:10:08 -0400 Original-Received: from [140.186.70.92] (port=41854 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Os4gB-0006YT-Gn for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 22:10:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Os4g9-0005uy-NY for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 22:09:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34483) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Os4g9-0005uu-MG for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 22:09:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Os4On-0006ZG-O1; Sat, 04 Sep 2010 21:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Sep 2010 01:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6956-submit@debbugs.gnu.org id=B6956.128365152025240 (code B ref 6956); Sun, 05 Sep 2010 01:52:01 +0000 Original-Received: (at 6956) by debbugs.gnu.org; 5 Sep 2010 01:52:00 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Os4Om-0006Z3-5T for submit@debbugs.gnu.org; Sat, 04 Sep 2010 21:52:00 -0400 Original-Received: from pantheon-po45.its.yale.edu ([130.132.50.79]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Os4Ol-0006Yy-3x for 6956@debbugs.gnu.org; Sat, 04 Sep 2010 21:51:59 -0400 Original-Received: from furry (adsl-99-89-95-190.dsl.wlfrct.sbcglobal.net [99.89.95.190]) (authenticated bits=0) by pantheon-po45.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o851rmBd015495 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Sep 2010 21:53:48 -0400 Original-Received: by furry (Postfix, from userid 1000) id 4F0D6C018; Sat, 4 Sep 2010 21:53:47 -0400 (EDT) In-Reply-To: <4C82BC4E.4080500@harpegolden.net> (David De La Harpe Golden's message of "Sat, 04 Sep 2010 22:38:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 04 Sep 2010 21:52:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39981 Archived-At: Thanks, the patch looks generally OK, except for the following: > (defcustom mouse-drag-copy-region nil > - "If non-nil, mouse drag copies region to kill-ring." > + "If non-nil, copy to kill-ring upon mouse adjustments of the region. > + > +For consistency this affects both actual mouse drag operations and > +`mouse-save-then-kill' (\\[mouse-save-then-kill]) operations that > +change the region." It is sufficient to say "This affects `mouse-save-then-kill' (\\[mouse-save-then-kill]) in addition to mouse drags." > If the region is inactive, activate it temporarily. Set mark at > the original point, and move point to the position of CLICK. > +If `mouse-drag-copy-region' is non-nil, also save the region > +to the kill ring. > > If the region is already active, adjust it. Normally, do this by > moving point or mark, whichever is closer, to CLICK. But if you > have selected whole words or lines, move point or mark to the > word or line boundary closest to CLICK instead. > +If `mouse-drag-copy-region' is non-nil, also save the region > +to the kill ring, replacing the previous kill corresponding > +to the already active region. We don't need to explain what mouse-drag-copy-region does twice. Just add a separate paragraph saying If `mouse-drag-copy-region' is non-nil, this command also saves the region to the kill ring, replacing the previous kill if it was also made with `mouse-save-then-kill'. > If this command is called a second consecutive time with the same > -CLICK position, kill the region." > +CLICK position, kill the region (or delete it > +if `mouse-drag-copy-region' is non-nil - it will already > +have been saved to the kill ring by the previous click.)" Omit the part after the "-", it's not necessary. > - (kill-region (mark t) (point)) > + (if mouse-drag-copy-region > + ;; region already saved the previous click, > + ;; don't make a duplicate entry, just delete > + (delete-region (mark t) (point)) > + (kill-region (mark t) (point))) > + (setq deactivate-mark t) What's the additional deactivate-mark for?