From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Wed, 22 Sep 2010 14:16:30 +0200 Organization: Organization?!? Message-ID: <87pqw6q8gx.fsf@lola.goethe.zz> References: <834odivv7v.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285157816 9434 80.91.229.12 (22 Sep 2010 12:16:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 22 Sep 2010 12:16:56 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 22 14:16:51 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OyOFm-000295-QG for ged-emacs-devel@m.gmane.org; Wed, 22 Sep 2010 14:16:51 +0200 Original-Received: from localhost ([127.0.0.1]:51800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OyOFm-0003tP-78 for ged-emacs-devel@m.gmane.org; Wed, 22 Sep 2010 08:16:50 -0400 Original-Received: from [140.186.70.92] (port=43422 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OyOFe-0003sQ-6H for emacs-devel@gnu.org; Wed, 22 Sep 2010 08:16:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OyOFd-0004Xi-0v for emacs-devel@gnu.org; Wed, 22 Sep 2010 08:16:42 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36843) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OyOFc-0004XX-R8 for emacs-devel@gnu.org; Wed, 22 Sep 2010 08:16:40 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OyOFZ-00023B-Tr for emacs-devel@gnu.org; Wed, 22 Sep 2010 14:16:37 +0200 Original-Received: from p508ed5f2.dip.t-dialin.net ([80.142.213.242]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Sep 2010 14:16:37 +0200 Original-Received: from dak by p508ed5f2.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Sep 2010 14:16:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: p508ed5f2.dip.t-dialin.net X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:ffZybvEo8Rd0GmhrI94CuVYFQ2Q= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130610 Archived-At: Eli Zaretskii writes: > We have this in insdel.c:make_gap_larger: > > { EMACS_INT total_size = Z_BYTE - BEG_BYTE + GAP_SIZE + nbytes_added; > if (total_size < 0 > /* Don't allow a buffer size that won't fit in a Lisp integer. */ > || total_size != XINT (make_number (total_size)) > /* Don't allow a buffer size that won't fit in an int > even if it will fit in a Lisp integer. > That won't work because so many places still use `int'. */ > || total_size != (EMACS_INT) (int) total_size) > error ("Buffer exceeds maximum size"); > > "bzr annotate" says this was committed a year ago by Stefan. > > Any objections to removing this limitation on 64-bit machines? I should think that this would call for a code review of Emacs' C modules first. -- David Kastrup