From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bugfix eshell/rm Date: Sat, 12 Mar 2011 09:45:00 +0100 Message-ID: <87pqpwd8xf.fsf@gmail.com> References: <8762rqozgo.fsf@gmail.com> <87wrk4eo6h.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299919532 13532 80.91.229.12 (12 Mar 2011 08:45:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2011 08:45:32 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 09:45:29 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PyKRx-0002BN-1P for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 09:45:25 +0100 Original-Received: from localhost ([127.0.0.1]:49341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyKRv-00052s-GI for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 03:45:23 -0500 Original-Received: from [140.186.70.92] (port=33274 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyKRo-00052T-I8 for emacs-devel@gnu.org; Sat, 12 Mar 2011 03:45:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PyKRm-00051W-SX for emacs-devel@gnu.org; Sat, 12 Mar 2011 03:45:15 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:51374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PyKRm-0004zn-KI for emacs-devel@gnu.org; Sat, 12 Mar 2011 03:45:14 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PyKRk-00027S-Uo for emacs-devel@gnu.org; Sat, 12 Mar 2011 09:45:12 +0100 Original-Received: from 244.211.85-79.rev.gaoland.net ([79.85.211.244]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 12 Mar 2011 09:45:12 +0100 Original-Received: from thierry.volpiatto by 244.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 12 Mar 2011 09:45:12 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 244.211.85-79.rev.gaoland.net User-Agent: Gnus/5.110014 (No Gnus v0.14) Emacs/23.3 (gnu/linux) Cancel-Lock: sha1:9ozOcIVok5ziVkBhJW2LbIivTZ0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137142 Archived-At: Thierry Volpiatto writes: > Glenn Morris writes: > >> Thierry Volpiatto wrote: >> >>> `eshell-remove-entries' use a not bound 'verbose' variable, and fail. >> >> It's dynamically bound in eshell/rm via eshell-eval-using-options. >> >>> To reproduce bug, try "rm -rf /some/directory" in eshell. >> >> Works fine for me. > Sorry to insist, but something is wrong here. > On emacs-23.3, if you turn on `delete-by-moving-to-trash', > rm -rf hang forever. > This is because in `eshell-remove-entries', `delete-directory' and > `delete-file' take respectively 3 and 2 arguments. > This is correct for emacs24 but not for emacs23. > > Use a consequent directory to test, i.e not a too small directory. > > So of course in emacs24 this is working fine. > > Maybe some changes in em-unix.el for emacs24 have been merged in > emacs-23 branch without appropriate modifications? So now back in emacs23, if i remove the 3 and 2 arguments to delete-directory and delete-file, reeval eshell-remove-entries and eshell/rm, all work fine. --8<---------------cut here---------------start------------->8--- (eshell-funcalln 'delete-directory (car files) t t) ^ removed (eshell-funcalln 'delete-file (car files) t) ^ removed --8<---------------cut here---------------end--------------->8--- -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997