all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Johan Bockgård" <bojohan@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 2490@debbugs.gnu.org
Subject: bug#2490: compilation only highlights the "E" of error
Date: Tue, 12 Jul 2011 16:42:58 +0200	[thread overview]
Message-ID: <87pqlfa7bh.fsf@gnu.org> (raw)
In-Reply-To: <m3fwmbsmw4.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 14:29:15 +0200")

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Johan Bockgård <bojohan@gnu.org> writes:
>
>> font-lock-keywords -> compilation--ensure-parse ->
>> compilation--parse-region -> compilation-parse-errors ->
>> compilation-error-regexp-alist-alist
>>
>> The lines in *Compile-Log* are matched by the `gnu' entry in
>> compilation-error-regexp-alist-alist (try `compilation-debug'):
>
> Thanks for finding this.  I've now installed a patch that seems to fix
> the bug.

The compiler output is classified as error/warning/info based on which
part of the expression that matched (see compilation-error-regexp-alist).
Your change marks "...:Error" as a warning:

--- a/lisp/progmodes/compile.el	2011-07-05 15:31:22 +0000
+++ b/lisp/progmodes/compile.el	2011-07-12 12:28:35 +0000
@@ -251,7 +251,7 @@
 \\([0-9]*[^0-9\n]\\(?:[^\n :]\\| [^-/\n]\\|:[^ \n]\\)*?\\): ?\
 \\([0-9]+\\)\\(?:[.:]\\([0-9]+\\)\\)?\
 \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\
-\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
+\\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\|[Ee]rror\\)\\|\
  *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\|instantiated from\\|[Nn]ote\\)\\|\
 \[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
      1 (2 . 4) (3 . 5) (6 . 7))
                         ^^^^^

6th subexpression matches => warning
7th subexpression matches => info
otherwise => error


I installed this patch instead:

=== modified file 'lisp/progmodes/compile.el'
--- lisp/progmodes/compile.el	2011-07-05 15:31:22 +0000
+++ lisp/progmodes/compile.el	2011-07-12 14:14:25 +0000
@@ -253,7 +253,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?
 \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
  *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\|instantiated from\\|[Nn]ote\\)\\|\
-\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
+ *[Ee]rror\\|\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
      1 (2 . 4) (3 . 5) (6 . 7))





  reply	other threads:[~2011-07-12 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27  3:29 bug#2490: compilation only highlights the "E" of error Glenn Morris
2011-07-10 16:26 ` Lars Magne Ingebrigtsen
2011-07-11 21:12   ` Johan Bockgård
2011-07-12 12:29     ` Lars Magne Ingebrigtsen
2011-07-12 14:42       ` Johan Bockgård [this message]
2011-07-12 14:44         ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqlfa7bh.fsf@gnu.org \
    --to=bojohan@gnu.org \
    --cc=2490@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.