From: David Maus <dmaus@ictsoc.de>
To: David Maus <dmaus@ictsoc.de>
Cc: Bastien <bzg@altern.org>, emacs-orgmode@gnu.org
Subject: Re: New feature: loop over siblings for some commands
Date: Wed, 20 Jul 2011 21:46:59 +0200 [thread overview]
Message-ID: <87pql4g2fg.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <87zkkayvld.wl%dmaus@ictsoc.de>
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
After a first look at the macro and its usage I have the feeling that
the macro would be wrong and/or a bad design choice.
It conditionally implements a mapping of body to a headline's
siblings. Thus it is a specialized case of applying a function to zero
or more headlines based on a selection criteria: In other words it is
a special case of org-map-entries.
So first there is duplicate code. Second the usage of the macro in for
instance `org-schedule'. The macro is wrapped around the entire
function body (except the interactive expression) and its only use is
avoidance of creating a separate function with the scheduling
implementation.
I highly recommend to not use this macro but to build the intended
functionality with separate building blocks: Factor out the flesh of
the respective functions (e.g. org-schedule) and use org-map-entries
to map. As far as I can see, the latter provides all we need:
(org-map-entries FUNC &optional MATCH SCOPE &rest SKIP)
We have FUNC (schedule) and MATCH (siblings). Region is the SCOPE (we
have to extend map-entries here). We might even extend the syntax of
MATCH to accept symbols indicating concepts like "sibling" and the
like. Ideally:
#+begin_src emacs-lisp
(if (or (not (org-region-active-p))
(not org-loop-over-siblings-within-active-region-p)) ;; -p? its not a predicate function!
(org-really-do-the-schedule)
(org-map-entries 'org-really-do-the-schedule 'siblings 'region))
#+end_src
Another abstraction: Instead
'org-loop-over-siblings-with-active-region' something like:
'org-loop-over-headlines-with-active-region' that can be set to a
symbol or a list of symbols indicating which headings to loop over
(e.g. 'siblings, 'children, ...).
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]
next prev parent reply other threads:[~2011-07-20 19:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 8:32 New feature: loop over siblings for some commands Bastien
2011-07-19 18:27 ` David Maus
2011-07-20 19:46 ` David Maus [this message]
2011-07-27 15:28 ` Bastien
2011-07-27 18:47 ` David Maus
2011-07-28 8:54 ` Bastien
2011-08-10 8:34 ` David Maus
2011-08-12 7:58 ` David Maus
2011-08-16 16:36 ` Bastien
2011-08-25 4:25 ` [PATCH 0/5] loop over headlines in active region David Maus
2011-08-25 6:13 ` Carsten Dominik
2011-08-28 13:58 ` David Maus
2011-08-29 9:29 ` Carsten Dominik
2011-08-30 4:36 ` David Maus
2011-08-25 10:08 ` Štěpán Němec
2011-08-28 13:57 ` David Maus
2011-09-07 19:34 ` Štěpán Němec
2011-09-09 4:06 ` David Maus
2011-09-09 10:26 ` Štěpán Němec
2011-09-09 10:41 ` Bastien
2011-09-09 10:46 ` Štěpán Němec
2011-09-09 15:10 ` David Maus
2011-09-09 15:26 ` Štěpán Němec
2011-09-09 15:52 ` David Maus
2011-10-06 8:35 ` Carsten Dominik
2011-10-08 18:59 ` David Maus
2011-10-08 20:11 ` Carsten Dominik
2011-10-08 20:55 ` David Maus
2011-08-25 4:25 ` [PATCH 1/5] Extend scope 'region to include body of last headline " David Maus
2011-08-25 5:40 ` Carsten Dominik
2011-08-30 4:33 ` David Maus
2011-08-25 4:25 ` [PATCH 2/5] Immediately return if scope is region but no region is active David Maus
2011-08-25 5:43 ` Carsten Dominik
2011-08-28 14:00 ` David Maus
2011-08-29 9:31 ` Carsten Dominik
2011-08-30 4:40 ` David Maus
2011-08-25 4:25 ` [PATCH 3/5] New customization variable: Loop over headlines in active region David Maus
2011-08-25 4:25 ` [PATCH 4/5] Skip invisible headlines when mapping " David Maus
2011-08-25 4:25 ` [PATCH 5/5] Avoid conflict between bulk command and loop-over-headlines David Maus
2011-10-22 14:23 ` Bastien
2011-07-27 15:23 ` New feature: loop over siblings for some commands Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pql4g2fg.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.