From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to support a prefix argument following suggesion by Juri Linkov Date: Fri, 27 Jan 2012 03:44:53 +0200 Organization: JURTA Message-ID: <87pqe5x6ju.fsf@mail.jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1327629183 2575 80.91.229.12 (27 Jan 2012 01:53:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 27 Jan 2012 01:53:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Gideon Stupp Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 27 02:52:58 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rqazp-0000pm-PP for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2012 02:52:57 +0100 Original-Received: from localhost ([::1]:45011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqazp-0002ua-6H for ged-emacs-devel@m.gmane.org; Thu, 26 Jan 2012 20:52:57 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:51788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqazm-0002uE-9K for emacs-devel@gnu.org; Thu, 26 Jan 2012 20:52:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqazl-0006jj-8O for emacs-devel@gnu.org; Thu, 26 Jan 2012 20:52:54 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:53801 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqazk-0006jf-W9 for emacs-devel@gnu.org; Thu, 26 Jan 2012 20:52:53 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 47435451C762; Thu, 26 Jan 2012 17:51:45 -0800 (PST) In-Reply-To: (Gideon Stupp's message of "Thu, 26 Jan 2012 19:27:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 69.163.218.105 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147964 Archived-At: > Please try it out. Thanks. A few comments below: > + ;; Bring universal-argument and friends back in > + (define-key map "\C-u" 'universal-argument) > + (define-key map (kbd "C--") 'negative-argument) > + (define-key map (kbd "C-0") 'digit-argument) > + (define-key map (kbd "C-1") 'digit-argument) > + (define-key map (kbd "C-2") 'digit-argument) > + (define-key map (kbd "C-3") 'digit-argument) > + (define-key map (kbd "C-4") 'digit-argument) > + (define-key map (kbd "C-5") 'digit-argument) > + (define-key map (kbd "C-6") 'digit-argument) > + (define-key map (kbd "C-7") 'digit-argument) > + (define-key map (kbd "C-8") 'digit-argument) > + (define-key map (kbd "C-9") 'digit-argument) > + (define-key meta-map (kbd "-") 'negative-argument) > + (define-key meta-map (kbd "C--") 'negative-argument) > + (define-key meta-map (kbd "C-0") 'digit-argument) > + (define-key meta-map (kbd "C-1") 'digit-argument) > + (define-key meta-map (kbd "C-2") 'digit-argument) > + (define-key meta-map (kbd "C-3") 'digit-argument) > + (define-key meta-map (kbd "C-4") 'digit-argument) > + (define-key meta-map (kbd "C-5") 'digit-argument) > + (define-key meta-map (kbd "C-6") 'digit-argument) > + (define-key meta-map (kbd "C-7") 'digit-argument) > + (define-key meta-map (kbd "C-8") 'digit-argument) > + (define-key meta-map (kbd "C-9") 'digit-argument)) Instead of adding these keybindings, you can just set `isearch-allow-scroll' to t. Also there are plans to add a better variable `isearch-enable-prefix' in 24.2, you can see more information at this link - http://thread.gmane.org/gmane.emacs.devel/143829 > -(defun isearch-repeat-forward () > +(defun isearch-repeat-forward (arg) > -(defun isearch-repeat-backward () > +(defun isearch-repeat-backward (arg) Please use (&optional arg) for backward-compatibility. > + (setq hint (number-to-string count)) > + (setq count (1+ count)) > + (set-text-properties 0 (length hint) '(face lazy-highlight-hint) hint) > + (overlay-put ov 'before-string hint))) A suggestion by Tassilo to use superscripts looks good too, but then these hints look like references to footnotes :-)