From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernt Hansen <bernt@norang.ca>
Subject: Re: org-publish-validate-link ?
Date: Tue, 28 Feb 2012 07:42:04 -0500
Message-ID: <87pqczf7tv.fsf@norang.ca>
References: <87ty2bbo9e.fsf@iro.umontreal.ca> <7251.1330403983@alphaville>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:55929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bernt@norang.ca>) id 1S2MNm-0004GT-LM
	for emacs-orgmode@gnu.org; Tue, 28 Feb 2012 07:42:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bernt@norang.ca>) id 1S2MNk-0006oj-D4
	for emacs-orgmode@gnu.org; Tue, 28 Feb 2012 07:42:18 -0500
Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:49041)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bernt@norang.ca>) id 1S2MNk-0006nZ-9J
	for emacs-orgmode@gnu.org; Tue, 28 Feb 2012 07:42:16 -0500
In-Reply-To: <7251.1330403983@alphaville> (Nick Dokos's message of "Mon, 27
	Feb 2012 23:39:43 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: nicholas.dokos@hp.com
Cc: =?us-ascii?Q?=22=3D=3Futf-8=3FQ=3FFran=3DC3?= =?us-ascii?Q?=3DA7ois=3F=3D=22?= Pinard <pinard@iro.umontreal.ca>, emacs-orgmode@gnu.org

Nick Dokos <nicholas.dokos@hp.com> writes:

> Fran=C3=A7ois Pinard <pinard@iro.umontreal.ca> wrote:
>
>
>> The manual, in [[info:org#Publishing%20links][Publishing links]],
>> speaks about an *org-publish-validate-link* function which does not seem
>> to exist in Org mode sources.  Is the function missing, or the
>> documentation misleading? :-)
>>=20
>
> It was removed by Sebastian Rose in a cleaning binge back in 2010,
> with the rationale that it was not being used anywhere:
>
> ,----
> | commit 339d6fe4bbf7b9858c6323d01f32d0c73a4cd3a8
> | Author: Sebastian Rose <sebastian_rose@gmx.de>
> | Date:   Thu May 13 13:43:53 2010 +0200
> |=20
> |         ...
> |=20=20=20=20=20
> |     	* org-publish.el (org-publish-validate-link) was not used
> |     	anywhere. Removed.
> |=20=20=20=20=20
> |         ...
> `----
>
> Apparently that had happened before because there is also this:
>
> ,----
> | commit d1f91f7e936b1d3caf1b17f0fe755ee085256442
> | Author: Carsten Dominik <carsten.dominik@gmail.com>
> | Date:   Sun Nov 2 16:20:40 2008 +0100
> |=20
> |     Re-introduce the org-publish-validate-link function.
> `----
>
> but I cannot find the previous deletion.

From=20
git log -Sdefun\ org-publish-validate-link

,----
| commit b05bc10e6794c902df679b906d8bd6ec3f5633a9
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Sun Mar 2 14:14:52 2008 +0000
|=20
|     Cleaned up code.
|=20
`----

-Bernt

>
> It was originally introduced with the following commit:
>
> ,----
> | commit 8fd900c6842d6f8d216ae6989b34c8de4a874e79
> | Author: Carsten Dominik <dominik@nb-dominik2.science.uva.nl>
> | Date:   Thu Jan 31 11:32:08 2008 +0100
> |=20
> |     Release 4.40
> |=20
> |     ...
> |=20
> | +;;;; Checking filenames against this hash
> | +
> | +
> | +(defun org-publish-validate-link (link)
> | +  (gethash (file-truename link) org-publish-files))
> | +
> | +
> |=20
> |     ...
> `----
>
> I presume it's time to add it back in, this time with a note: "Do NOT
> delete: this function may look unused, but it's referred to from the
> manual!"
>
> Archaelogy is kind of fun ;-)
>
> Nick