From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.bugs Subject: bug#11373: [PATCH] xterm.c: Use memcpy in place of unwarranted strncpy. Date: Sat, 28 Apr 2012 23:58:35 +0200 Message-ID: <87pqarmsc4.fsf@rho.meyering.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335650403 30960 80.91.229.3 (28 Apr 2012 22:00:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 Apr 2012 22:00:03 +0000 (UTC) To: 11373@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 29 00:00:02 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SOFgQ-00074K-0t for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Apr 2012 00:00:02 +0200 Original-Received: from localhost ([::1]:54557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFgP-0006Gy-Bk for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Apr 2012 18:00:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFgM-0006Gr-4P for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFgK-0000Mh-D6 for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:59:57 -0400 Original-Received: from [140.186.70.43] (port=56172 helo=debbugs.gnu.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFgK-0000In-9p for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:59:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SOFhN-0001WP-Sm for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Apr 2012 22:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13356504045763 (code B ref -1); Sat, 28 Apr 2012 22:01:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Apr 2012 22:00:04 +0000 Original-Received: from localhost ([127.0.0.1]:57206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOFgR-0001Ut-Gt for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:00:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50957) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOFgQ-0001U0-81 for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:00:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFfA-0007cb-1L for submit@debbugs.gnu.org; Sat, 28 Apr 2012 17:58:45 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:35900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFf9-0007cX-UX for submit@debbugs.gnu.org; Sat, 28 Apr 2012 17:58:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFf8-0006GS-83 for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:58:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFf6-0007cC-Ff for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:58:41 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:33606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFf6-0007c7-Cl for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 17:58:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55633) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SOFf5-0004zA-Pt for bug-emacs@gnu.org; Sat, 28 Apr 2012 17:58:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFf3-0007bo-K8 for bug-emacs@gnu.org; Sat, 28 Apr 2012 17:58:38 -0400 Original-Received: from mx.meyering.net ([88.168.87.75]:54328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFf3-0007bi-DV for bug-emacs@gnu.org; Sat, 28 Apr 2012 17:58:37 -0400 Original-Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 725AD6025C for ; Sat, 28 Apr 2012 23:58:35 +0200 (CEST) Original-Lines: 38 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59607 Archived-At: There's no reason to use strncpy here, and using it is misleading. 2012-04-28 Jim Meyering * xterm.c (x_term_init): Use memcpy in place of unwarranted strncpy. --- src/ChangeLog | 4 ++++ src/xterm.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index 2792901..6ec58f9 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2012-04-26 Jim Meyering + + * xterm.c (x_term_init): Use memcpy in place of unwarranted strncpy. + 2012-04-24 Chong Yidong * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315). diff --git a/src/xterm.c b/src/xterm.c index 9ce1668..2922b05 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -10146,7 +10146,7 @@ x_term_init (Lisp_Object display_name, char *xrm_option, char *resource_name) /* Set the name of the terminal. */ terminal->name = (char *) xmalloc (SBYTES (display_name) + 1); - strncpy (terminal->name, SSDATA (display_name), SBYTES (display_name)); + memcpy (terminal->name, SSDATA (display_name), SBYTES (display_name)); terminal->name[SBYTES (display_name)] = 0; #if 0 -- 1.7.10.382.g62bc8