From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames. Date: Wed, 01 Aug 2012 11:38:28 -0600 Message-ID: <87pq7av7fv.fsf@fleche.redhat.com> References: <50191B54.2070705@yandex.ru> <50194432.8000808@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1343844735 24004 80.91.229.3 (1 Aug 2012 18:12:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2012 18:12:15 +0000 (UTC) Cc: Dmitry Antipov , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 01 20:12:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwdP4-0001x3-I0 for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2012 20:12:14 +0200 Original-Received: from localhost ([::1]:49430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwdP3-0004ll-M7 for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2012 14:12:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwdP1-0004lO-50 for emacs-devel@gnu.org; Wed, 01 Aug 2012 14:12:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwdP0-0000Kr-08 for emacs-devel@gnu.org; Wed, 01 Aug 2012 14:12:11 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:1428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwdOz-0000Ki-OI for emacs-devel@gnu.org; Wed, 01 Aug 2012 14:12:09 -0400 Original-Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q71IBxmF011739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Aug 2012 14:12:08 -0400 Original-Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q71HcSXX018213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 1 Aug 2012 13:38:29 -0400 X-Attribution: Tom In-Reply-To: <50194432.8000808@cs.ucla.edu> (Paul Eggert's message of "Wed, 01 Aug 2012 07:58:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152087 Archived-At: >>>>> "Paul" == Paul Eggert writes: Paul> While we're on the topic, the code is currently sloppy Paul> about using ASET; sometimes it uses 'AREF (a, b) = c' Paul> rather than 'ASET (a, b, c)'. I suppose this will Paul> need fixing too. It probably should be fixed regardless Paul> of any GC changes. It isn't just ASET but many accessors of many objects. Also, when I looked into this, there were places that take the address of a field of a Lisp_Object and pass that around... more stuff to fix if you want a software write barrier. FWIW I think it is an interesting project, and the problems are all surmountable. Tom