Bug: startup: hidestars does not use the real window background color [7.8.11]

Bug: startup: hidestars does not use the real window background color [7.8.11]

[Arne Babenhauserheide (IMK)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
- ------------------------------------------------------------------------

Dear org Hackers,

I use a custom color scheme in KDE with brown window background color,
and when I activate #+STARTUP: hidestars, the first stars are white
instead of brown.

My color scheme is Antiford
? http://opendesktop.org/content/show.php/Antiford?content=142571

Best wishes,
Arne



Emacs  : GNU Emacs 23.4.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.10)
 of 2012-07-10 on ********
Package: Org-mode version 7.8.11

current state:
==============
(setq
 org-ditaa-jar-path "~/.emacs.d/private/org/ditaa0_9/ditaa0_9.jar"
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-export-latex-listings 'minted
 org-speed-command-hook '(org-speed-command-default-hook
org-babel-speed-command-hook)
 org-agenda-custom-commands '(("o" "Agenda and TODOs" ((tags "KANBAN")
(agenda nil) (todo "" "~/plan.org"))))
 org-agenda-files '("~/plan.org")
 org-agenda-include-diary t
 org-babel-load-languages '((python . t) (sh . t) (emacs-lisp . t)
(ditaa . t) (dot . t) (C . t) (R . t) (gnuplot . t)
                            (org . t))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-babel-tangle-lang-exts '(("C++" . "cpp") ("python" . "py")
("emacs-lisp" . "el"))
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-agenda-skip-scheduled-if-done t
 org-latex-to-pdf-process '("pdflatex -interaction nonstopmode
- -shell-escape -output-directory %o %f" "bibtex $(basename %b)"
                            "pdflatex -interaction nonstopmode
- -shell-escape -output-directory %o %f"
                            "pdflatex -interaction nonstopmode
- -shell-escape -output-directory %o %f")
 org-tab-first-hook '(org-hide-block-toggle-maybe
org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-export-latex-packages-alist '(("" "color") ("" "minted"))
 org-default-notes-file "~/.emacs.d/private/org/emacs-remember-mode.org"
 org-directory "~/.emacs.d/private/org"
 outline-mode-hook '((lambda nil (require (quote outline-magic))))
 org-babel-pre-tangle-hook '(save-buffer)
 org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-export-latex-classes '(("article"
"\\documentclass[11pt]{scrartcl}" ("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" .
"\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}")
                             ("\\paragraph{%s}" . "\\paragraph*{%s}")
("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
                            ("report"
"\\documentclass[11pt]{scrreprt}" ("\\part{%s}" . "\\part*{%s}")
                             ("\\chapter{%s}" . "\\chapter*{%s}")
("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" .
"\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}")
                             ("\\paragraph{%s}" . "\\paragraph*{%s}")
("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
                            ("book" "\\documentclass[11pt]{scrbook}"
("\\part{%s}" . "\\part*{%s}")
                             ("\\chapter{%s}" . "\\chapter*{%s}")
("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" .
"\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                            ("beamer" "\\documentclass{beamer}"
org-beamer-sectioning))
 org-export-preprocess-before-normalizing-links-hook
'(org-remove-file-link-modifiers)
 org-mode-hook '(org-mode-reftex-setup turn-on-font-lock
                 #[nil "\300\301\302\303\304$\207" [org-add-hook
change-major-mode-hook org-show-block-all append local] 5]
                 #[nil "\300\301\302\303\304$\207" [org-add-hook
change-major-mode-hook org-babel-show-result-all append local]
                   5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-extend-today-until 4
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
org-babel-execute-safely-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-start-on-weekday nil
 org-export-interblocks '((src org-babel-exp-non-block-elements))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-agenda-skip-deadline-if-done t
 org-occur-hook '(org-first-headline-recenter)
 org-from-is-user-regexp nil
 org-export-preprocess-before-selecting-backend-code-hook
'(org-beamer-select-beamer-code)
 outline-minor-mode-hook '((lambda nil (require (quote outline-magic)))
                           (lambda nil (require (quote outline-magic))
                            (define-key outline-minor-mode-map [(f10)]
(quote outline-cycle)))
                           )
 org-remember-templates '(("todo" 116 "?: %?\n"
"~/.emacs.d/private/org/emacs-plan.org" nil nil)
                          ("Note" 110 "%?\n" nil nil nil))
 org-export-latex-final-hook '(org-beamer-amend-header
org-beamer-fix-toc org-beamer-auto-fragile-frames
                               org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-abbrev-alist '(("bib" . "~/aufschriebe/ref.bib::%s")
("notes" . "~/aufschriebe/papers.org::#%s")
                         ("papers" . "~/aufschriebe/papers/%s.pdf"))
 org-export-blocks '((src org-babel-exp-src-block nil) (export-comment
org-export-blocks-format-comment t)
                     (ditaa org-export-blocks-format-ditaa nil) (dot
org-export-blocks-format-dot nil))
 )
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJQRZ1VAAoJEFyD82SnDaCew48IAJOnDUS+/HUH+sAfEhPce744
rc/UeTq89SWHa4M1X2C7Zbq/6Dy6fV6Mexz2T/oND08MCpvQiQ5ZluIv/efnYI9J
HQ9OQbtk6sZDIWdKxvB4IA9l+7ZRUC5umla7xlXT9+Q58XBsCnWIk7UjDD7vQtrs
D32XTsKCh8v81pxx71bl3A8HCZpvowA/DELdr8+CRZfXST77LjeJnTcB+Nm3UYW3
z/gWVIi4hd4ewmCwHcqrnBVJwWE39Hp2ecNaGgWAq/E4hT2IjrpJBZ2m2h22QS6V
EvDd668JHSkActIroPJNnzQ+raoB5Cb8tTgw+AXEReQ4lU5qQD1US+dt3HTPzTQ=
=KQJV
-----END PGP SIGNATURE-----

Re: Bug: startup: hidestars does not use the real window background color [7.8.11]

[Bastien]

Hi Arne,

"Arne Babenhauserheide (IMK)" <arne.babenhauserheide@kit.edu> writes:

> Dear org Hackers,
>
> I use a custom color scheme in KDE with brown window background color,
> and when I activate #+STARTUP: hidestars, the first stars are white
> instead of brown.
>
> My color scheme is Antiford
> ? http://opendesktop.org/content/show.php/Antiford?content=142571

This is now fixed: the `org-hide' face is a bit more clever when trying
the get the background color.

Thanks,

-- 
 Bastien

Re: Bug: startup: hidestars does not use the real window background color [7.8.11]

[Arne Babenhauserheide (IMK)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Bastien,

That’s great, thanks!

Best wishes,
Arne

Am 18.09.2012 12:25, schrieb Bastien:
> Hi Arne,
> 
> "Arne Babenhauserheide (IMK)" <arne.babenhauserheide@kit.edu>
> writes:
> 
>> Dear org Hackers,
>> 
>> I use a custom color scheme in KDE with brown window background
>> color, and when I activate #+STARTUP: hidestars, the first stars
>> are white instead of brown.
>> 
>> My color scheme is Antiford ?
>> http://opendesktop.org/content/show.php/Antiford?content=142571
> 
> This is now fixed: the `org-hide' face is a bit more clever when
> trying the get the background color.
> 
> Thanks,
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJQWHIBAAoJEFyD82SnDaCeb+0IAKOflOrD/pzUJarzVLTzwYPx
SBIy3oLtYgjQ1NTgBo2jWgi3goElps5JIMDGL1ZZmdm5RHi+bpPBReJJvUq4Hm04
5zstB0YCwC+LTRb+xfHX2kXdISugjuO+dDfCsdWE2G9Hcrt48bmtZRAWG62ge4iV
tWlsNZjy41j/FBPlYbXdMHrIeHYbrn/N5To2PniCR59he5JEOPdlpL4vqTg8ZrkW
kv7Pjwt4x7pofiJ2MfWQeQ3dCG+YhDe07B2HQU+F0whaCRvt0eLBWPEIfwFw44gH
p15O6FzlGnwlm1DrgcVzT+5r5Pi7E0iT974OBcs2rgg3ofwBYQ3s8KK6STrwywM=
=lX36
-----END PGP SIGNATURE-----

Re: Bug: startup: hidestars does not use the real window background color [7.8.11]

[Max Mikhanosha]

At Tue, 18 Sep 2012 12:25:04 +0200,
Bastien wrote:
> 
> Hi Arne,
> 
> "Arne Babenhauserheide (IMK)" <arne.babenhauserheide@kit.edu> writes:
> 
> > Dear org Hackers,
> >
> > I use a custom color scheme in KDE with brown window background color,
> > and when I activate #+STARTUP: hidestars, the first stars are white
> > instead of brown.
> >
> > My color scheme is Antiford
> > ? http://opendesktop.org/content/show.php/Antiford?content=142571
> 
> This is now fixed: the `org-hide' face is a bit more clever when trying
> the get the background color.

Just updated org, and this fix a problem for me in multi-tty emacs. On
the tty frames, the my default face background is "unspecified-bg",
which leaves background color alone (ie its whatever default
background xterm or other emulator uses)

This allows to have different xterm's with similar but differently
shaded backgrounds for different tasks, without changing background in
Emacs.

With this new fix, when org-mode file is visited on tty, it sets
'org-hide face foreground to "unspecified-bg" which makes all leading
stars reverse color.

Patch to fix this is pasted below.


From 1f0ef1241acd7c22fff275ae65a6bf2a9fd84f06 Mon Sep 17 00:00:00 2001
From: Max Mikhanosha <max@openchat.com>
Date: Fri, 28 Sep 2012 11:48:05 -0400
Subject: [PATCH] * lisp/org.el (org-mode): don't set org-hide foreground to
 "invisible-bg" (org-find-invisible-foreground): new
 function

---
 lisp/org.el | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index c47e2ad..7f09d15 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5144,14 +5144,7 @@ (define-derived-mode org-mode outline-mode "Org"
     (unless org-inhibit-startup-visibility-stuff
       (org-set-startup-visibility)))
   ;; Try to set org-hide correctly
-  (set-face-foreground
-   'org-hide
-   (or (face-background 'default)
-       (face-background 'org-default)
-       (cdr (assoc 'background-color default-frame-alist))
-       (cdr (assoc 'background-color initial-frame-alist))
-       (cdr (assoc 'background-color window-system-default-frame-alist))
-       (face-foreground 'org-hide))))
+  (set-face-foreground 'org-hide (org-find-invisible-foreground)))
 
 (when (fboundp 'abbrev-table-put)
   (abbrev-table-put org-mode-abbrev-table
@@ -5159,6 +5152,19 @@ (define-derived-mode org-mode outline-mode "Org"
 
 (put 'org-mode 'flyspell-mode-predicate 'org-mode-flyspell-verify)
 
+
+(defun org-find-invisible-foreground ()
+  (let ((candidates (remove
+		     "unspecified-bg" 
+		     (list 
+		      (face-background 'default) 
+		      (face-background 'org-default) 
+		      (cdr (assoc 'background-color default-frame-alist)) 
+		      (cdr (assoc 'background-color initial-frame-alist)) 
+		      (cdr (assoc 'background-color window-system-default-frame-alist)) 
+		      (face-foreground 'org-hide))))) 
+    (car (remove nil candidates))))
+
 (defun org-current-time ()
   "Current time, possibly rounded to `org-time-stamp-rounding-minutes'."
   (if (> (car org-time-stamp-rounding-minutes) 1)
-- 
1.7.11.rc0.100.g5498c5f

Re: Bug: startup: hidestars does not use the real window background color [7.8.11]

[Bastien]

Hi Max,

Max Mikhanosha <max@openchat.com> writes:

> Just updated org, and this fix a problem for me in multi-tty emacs. On
> the tty frames, the my default face background is "unspecified-bg",
> which leaves background color alone (ie its whatever default
> background xterm or other emulator uses)
>
> This allows to have different xterm's with similar but differently
> shaded backgrounds for different tasks, without changing background in
> Emacs.
>
> With this new fix, when org-mode file is visited on tty, it sets
> 'org-hide face foreground to "unspecified-bg" which makes all leading
> stars reverse color.
>
> Patch to fix this is pasted below.

Applied, thanks a lot!

-- 
 Bastien