From: Juri Linkov <juri@jurta.org>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 13016@debbugs.gnu.org, Chong Yidong <cyd@gnu.org>
Subject: bug#13016: 24.3.50; Inconsistency in the way of presenting the filename in info buffers.
Date: Sat, 08 Dec 2012 01:54:20 +0200 [thread overview]
Message-ID: <87pq2la1d7.fsf@mail.jurta.org> (raw)
In-Reply-To: <CAH8Pv0jA44U6O+h7wBWEwXSxpXSV8=Q0J82S7JeD4HrFO5iSjA@mail.gmail.com> (Dani Moncayo's message of "Fri, 7 Dec 2012 17:16:06 +0100")
> The original problem is fixed, but I still see one: After opening an
> info manual via `C-u C-h i ...', if I try to define a bookmark via
> `C-x r m', the default value in the minibuffer prompt does have the
> ".info" extension (like others default values brought by `M-n').
>
> The ".info" extension should be removed there too.
Searching the source file info.el for more occurrences of
(file-name-nondirectory Info-current-file)
also finds the same problem in other places
like when typing `w' (Info-copy-current-node-name),
and in `Info-breadcrumbs' and `Info-fontify-node'.
If using `file-name-sans-extension' is the right way
to fix them, then all they could be fixed with:
=== modified file 'lisp/info.el'
--- lisp/info.el 2012-12-07 23:15:16 +0000
+++ lisp/info.el 2012-12-07 23:53:00 +0000
@@ -4064,7 +4064,9 @@ (defun Info-copy-current-node-name (&opt
(unless Info-current-node
(user-error "No current Info node"))
(let ((node (if (stringp Info-current-file)
- (concat "(" (file-name-nondirectory Info-current-file) ") "
+ (concat "(" (file-name-sans-extension
+ (file-name-nondirectory Info-current-file))
+ ") "
Info-current-node))))
(if (zerop (prefix-numeric-value arg))
(setq node (concat "(info \"" node "\")")))
@@ -4451,7 +4453,8 @@ (defun Info-breadcrumbs ()
(if (not (equal node "Top")) node
(format "(%s)Top"
(if (stringp Info-current-file)
- (file-name-nondirectory Info-current-file)
+ (file-name-sans-extension
+ (file-name-nondirectory Info-current-file))
;; Some legacy code can still use a symbol.
Info-current-file)))))
(setq line (concat
@@ -4563,7 +4566,8 @@ (defun Info-fontify-node ()
(if (re-search-forward
(format "File: %s\\([^,\n\t]+\\),"
(if (stringp Info-current-file)
- (file-name-nondirectory Info-current-file)
+ (file-name-sans-extension
+ (file-name-nondirectory Info-current-file))
Info-current-file))
header-end t)
(put-text-property (match-beginning 1) (match-end 1)
@@ -5101,7 +5105,8 @@ (defun Info-bookmark-make-record ()
"This implements the `bookmark-make-record-function' type (which see)
for Info nodes."
(let* ((file (and (stringp Info-current-file)
- (file-name-nondirectory Info-current-file)))
+ (file-name-sans-extension
+ (file-name-nondirectory Info-current-file))))
(bookmark-name (if file
(concat "(" file ") " Info-current-node)
Info-current-node))
next prev parent reply other threads:[~2012-12-07 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 23:21 bug#13016: 24.3.50; Inconsistency in the way of presenting the filename in info buffers Dani Moncayo
2012-12-07 15:32 ` Chong Yidong
2012-12-07 16:16 ` Dani Moncayo
2012-12-07 23:54 ` Juri Linkov [this message]
2012-12-08 2:13 ` Chong Yidong
2012-12-08 23:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq2la1d7.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=13016@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=dmoncayo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.