From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aidan Gauland Newsgroups: gmane.emacs.devel Subject: Re: [Eshell patch] Visual subcommands and options Date: Sun, 02 Jun 2013 09:41:40 +1200 Message-ID: <87ppw5y0dn.fsf@dimension8.tehua.net> References: <87ehcn4drw.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1370122926 21045 80.91.229.3 (1 Jun 2013 21:42:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Jun 2013 21:42:06 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 01 23:42:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UitYq-0000aH-V7 for ged-emacs-devel@m.gmane.org; Sat, 01 Jun 2013 23:42:05 +0200 Original-Received: from localhost ([::1]:54464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UitYq-0000Nh-KU for ged-emacs-devel@m.gmane.org; Sat, 01 Jun 2013 17:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UitYn-0000NS-UC for emacs-devel@gnu.org; Sat, 01 Jun 2013 17:42:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UitYn-0002oE-0B for emacs-devel@gnu.org; Sat, 01 Jun 2013 17:42:01 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:48877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UitYm-0002oA-PP for emacs-devel@gnu.org; Sat, 01 Jun 2013 17:42:00 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UitYk-0000Ut-7H for emacs-devel@gnu.org; Sat, 01 Jun 2013 23:41:58 +0200 Original-Received: from 49.143.231.176 ([49.143.231.176]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Jun 2013 23:41:58 +0200 Original-Received: from aidalgol by 49.143.231.176 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Jun 2013 23:41:58 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 49.143.231.176 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Cancel-Lock: sha1:ui3rBs5aHya4G88azi+8xyxr4TA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159972 Archived-At: Tassilo Horn writes: > eshell shows the output of commands in `eshell-visual-commands' in a > term buffer. Those are typically interactive commands that show their > results in a pager or other interactive facility. Typical commands like > that are top, less, more, etc. > > However, until now you could only say "this command is visual". But > there are many commands I use regularly that usually are not visual > except when they are called with some special option or subcommand. > Typical examples are several VCS commands such as "git log", "git show", > "git diff", or "hg log" which show their output with a pager by default > and thus are then visual in eshell's sense. > > This patch adds two new defcustoms `eshell-visual-subcommands' and > `eshell-visual-options' that lets you also specifiy commands with > certain subcommands and options that make them visual. > > Any objections to installing this patch? Sounds good. I wouldn't use this myself, since I just set the PAGER environment variable to "cat", so the output is just dumped to the *eshell* buffer, but I would use this if any programs go into an ncurses mode only for some subcommands. I don't have anything against this being added, though, so go ahead! :) (And the patch looks sane enough.) --Aidan