all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: 14734@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Sat, 29 Jun 2013 00:27:21 +0200	[thread overview]
Message-ID: <87ppv550s6.fsf@web.de> (raw)
In-Reply-To: <jwvsj034e5b.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 27 Jun 2013 14:15:22 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> >  :around advice: `ad-Advice-isearch-forward'
> [...]
> > It is also incorrect.  The advice is :before, not :around.
>
> It is correct: the ad-Advice-isearch-forward advice is an around advice
> (and it is not your advice, it's internal as you say).
> If you click on it, you'll see your before advice, properly labeled.
>
> If you don't want to see the internal thingy, then use the new
> advice-add rather than the old defadvice.

Let me add that advice.el is not yet obsolete, and the manual still
explains the old advice.el.  We should try reach a consistent state,
i.e. C-h f should report information according to the package the user
is told to use.


Michael.





  parent reply	other threads:[~2013-06-28 22:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 17:08 bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Drew Adams
2013-06-27 18:15 ` Stefan Monnier
2013-06-27 18:40   ` Drew Adams
2013-06-28 17:39     ` Drew Adams
2013-06-28 20:44       ` Dmitry Gutov
2013-06-28 21:56         ` Drew Adams
2013-06-28 22:19           ` Michael Heerdegen
2019-09-23 21:07         ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27   ` Michael Heerdegen [this message]
2013-06-28 23:21     ` Stefan Monnier
2013-06-29  1:37       ` Drew Adams
2013-06-29  2:09         ` Stefan Monnier
2013-06-29  2:28           ` Drew Adams
2013-06-29  3:24             ` Stefan Monnier
2013-06-29 20:29               ` Juanma Barranquero
2013-06-30  1:39                 ` Stefan Monnier
2013-07-05 14:50                   ` Drew Adams
2013-07-05 14:57                     ` Juanma Barranquero
2013-07-05 22:44                     ` Stefan Monnier
2013-07-06  1:40                       ` Drew Adams
2013-07-06  9:18                         ` Stefan Monnier
2013-07-06 20:22                           ` Drew Adams
2013-10-20 23:27               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppv550s6.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=14734@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.