all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [elpa] 01/01: * company-capf.el (company--capf-data): Don't get confused by lambda exps.
       [not found] ` <E1W6lQT-0006KT-5K@vcs.savannah.gnu.org>
@ 2014-01-25 11:18   ` Dmitry Gutov
  2014-01-25 21:49     ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Gutov @ 2014-01-25 11:18 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier-CRDzTM1onBSWkKpYnGOUKg@public.gmane.org> writes:

>            (data (run-hook-wrapped 'completion-at-point-functions
>                                    ;; Ignore misbehaving functions.
>                                    #'completion--capf-wrapper 'optimist)))
> -    (when (consp data) data)))
> +    (when (and (consp data) (numberp (car data))) data)))

This will always fail because completion--capf-wrapper returns the
completion function itself in the car. START and END are at positions 1
and 2. I'll push a fixed version shortly.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] 01/01: * company-capf.el (company--capf-data): Don't get confused by lambda exps.
  2014-01-25 11:18   ` [elpa] 01/01: * company-capf.el (company--capf-data): Don't get confused by lambda exps Dmitry Gutov
@ 2014-01-25 21:49     ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-01-25 21:49 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: Stefan Monnier, emacs-devel

>> (data (run-hook-wrapped 'completion-at-point-functions
>> ;; Ignore misbehaving functions.
>> #'completion--capf-wrapper 'optimist)))
>> -    (when (consp data) data)))
>> +    (when (and (consp data) (numberp (car data))) data)))
> This will always fail because completion--capf-wrapper returns the
> completion function itself in the car.  START and END are at positions 1
> and 2. I'll push a fixed version shortly.

Duh!  Thanks for catching this.  I see now that I "tested" it without
recompiling, which is why it seemed to work as well as before.


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-25 21:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20140124182420.24272.98505@vcs.savannah.gnu.org>
     [not found] ` <E1W6lQT-0006KT-5K@vcs.savannah.gnu.org>
2014-01-25 11:18   ` [elpa] 01/01: * company-capf.el (company--capf-data): Don't get confused by lambda exps Dmitry Gutov
2014-01-25 21:49     ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.