* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
@ 2014-06-05 0:16 Leo Liu
2014-06-05 0:39 ` Juri Linkov
2014-06-05 1:09 ` Glenn Morris
0 siblings, 2 replies; 8+ messages in thread
From: Leo Liu @ 2014-06-05 0:16 UTC (permalink / raw
To: 17695
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Note: this bug doesn't happen in emacs 24.3.
1. emacs -Q
2. M-x load-theme RET deeper-blue RET
3. open a patch in diff-mode.
Face: diff-added (sample) (customize this face)
Documentation:
`diff-mode' face used to highlight added lines.
Defined in `diff-mode.el'.
Family: unspecified
Foundry: unspecified
Width: unspecified
Height: unspecified
Weight: unspecified
Slant: unspecified
Foreground: unspecified
DistantForeground: unspecified
Background: unspecified
Underline: unspecified
Overline: unspecified
Strike-through: unspecified
Box: unspecified
Inverse: unspecified
Stipple: unspecified
Font: unspecified
Fontset: unspecified
Inherit: unspecified
[-- Attachment #2: deepblue.png --]
[-- Type: image/png, Size: 31851 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 0:16 bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Leo Liu
@ 2014-06-05 0:39 ` Juri Linkov
2014-06-05 2:32 ` Leo Liu
2014-06-05 1:09 ` Glenn Morris
1 sibling, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2014-06-05 0:39 UTC (permalink / raw
To: Leo Liu; +Cc: 17695
> Note: this bug doesn't happen in emacs 24.3.
>
> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)
>
> Documentation:
> `diff-mode' face used to highlight added lines.
>
> Defined in `diff-mode.el'.
>
> Family: unspecified
> Foundry: unspecified
> Width: unspecified
> Height: unspecified
> Weight: unspecified
> Slant: unspecified
> Foreground: unspecified
> DistantForeground: unspecified
> Background: unspecified
> Underline: unspecified
> Overline: unspecified
> Strike-through: unspecified
> Box: unspecified
> Inverse: unspecified
> Stipple: unspecified
> Font: unspecified
> Fontset: unspecified
> Inherit: unspecified
This patch should fix it:
=== modified file 'etc/themes/deeper-blue-theme.el'
--- etc/themes/deeper-blue-theme.el 2014-01-01 07:43:34 +0000
+++ etc/themes/deeper-blue-theme.el 2014-06-05 00:38:30 +0000
@@ -40,8 +40,8 @@ (let ((class '((class color) (min-colors
`(cperl-hash-face ((,class (:foreground "coral1"))))
`(cursor ((,class (:background "green"))))
`(default ((,class (:background "#181a26" :foreground "gray80"))))
- `(diff-added ((,class (nil))))
- `(diff-changed ((,class (nil))))
+ `(diff-added ((,class (:inherit diff-indicator-added))))
+ `(diff-changed ((,class (:inherit diff-indicator-changed))))
`(diff-context ((,class (:foreground "seashell4"))))
`(diff-file-header ((,class (:background "grey60"))))
`(diff-function ((,class (:inherit diff-header))))
@@ -52,7 +52,7 @@ (let ((class '((class color) (min-colors
`(diff-indicator-changed ((,class (:foreground "white" :background "dodgerblue4"))))
`(diff-indicator-removed ((,class (:foreground "white" :background "indianred4"))))
`(diff-refine-change ((,class (:background "skyblue4"))))
- `(diff-removed ((,class (nil))))
+ `(diff-removed ((,class (:inherit diff-indicator-removed))))
`(dired-marked ((,class (:background "dodgerblue3" :foreground "white"))))
`(ediff-current-diff-A ((,class (:background "green4" :foreground "white"))))
`(ediff-current-diff-B ((,class (:background "darkorange3" :foreground "white"))))
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 0:16 bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Leo Liu
2014-06-05 0:39 ` Juri Linkov
@ 2014-06-05 1:09 ` Glenn Morris
2014-06-05 2:40 ` Leo Liu
1 sibling, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2014-06-05 1:09 UTC (permalink / raw
To: Leo Liu; +Cc: 17695
Leo Liu wrote:
> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)
I don't think this is a bug.
The theme specifies attribute "nil" for this face (and some others).
As NEWS says:
*** Face specs set via Custom themes now replace the `defface' spec
rather than inheriting from it
So the theme gets what it asked for - every attribute unspecified.
If this was not what the theme author intended, perhaps the theme should
be changed.
(As an aside, what is the difference between "regression" and
"REGRESSION", and what is either supposed to actually mean in practice...)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 0:39 ` Juri Linkov
@ 2014-06-05 2:32 ` Leo Liu
2014-06-05 23:33 ` Juri Linkov
0 siblings, 1 reply; 8+ messages in thread
From: Leo Liu @ 2014-06-05 2:32 UTC (permalink / raw
To: Juri Linkov; +Cc: 17695
On 2014-06-05 03:39 +0300, Juri Linkov wrote:
> This patch should fix it:
I can confirm the fix.
Cheers,
Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 1:09 ` Glenn Morris
@ 2014-06-05 2:40 ` Leo Liu
0 siblings, 0 replies; 8+ messages in thread
From: Leo Liu @ 2014-06-05 2:40 UTC (permalink / raw
To: Glenn Morris; +Cc: 17695
On 2014-06-04 21:09 -0400, Glenn Morris wrote:
> (As an aside, what is the difference between "regression" and
> "REGRESSION", and what is either supposed to actually mean in practice...)
The capitalisation is done by my fingers so they come out randomly.
I use it to mean something used to work stops working.
Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 2:32 ` Leo Liu
@ 2014-06-05 23:33 ` Juri Linkov
2014-06-06 9:28 ` Leo Liu
0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2014-06-05 23:33 UTC (permalink / raw
To: Leo Liu; +Cc: 17695-done
>> This patch should fix it:
>
> I can confirm the fix.
Regression is fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-05 23:33 ` Juri Linkov
@ 2014-06-06 9:28 ` Leo Liu
2014-06-06 23:07 ` Juri Linkov
0 siblings, 1 reply; 8+ messages in thread
From: Leo Liu @ 2014-06-06 9:28 UTC (permalink / raw
To: 17695
On 2014-06-06 02:33 +0300, Juri Linkov wrote:
> Regression is fixed.
After some more use, there is still difference between 24.3 and 24.4 for
those faces.
It seems best just remove or comment out those faces.
Thanks,
Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
2014-06-06 9:28 ` Leo Liu
@ 2014-06-06 23:07 ` Juri Linkov
0 siblings, 0 replies; 8+ messages in thread
From: Juri Linkov @ 2014-06-06 23:07 UTC (permalink / raw
To: Leo Liu; +Cc: 17695
> After some more use, there is still difference between 24.3 and 24.4 for
> those faces.
>
> It seems best just remove or comment out those faces.
The default faces are good indeed, so removing overridden faces
from the theme makes sense.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-06 23:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 0:16 bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Leo Liu
2014-06-05 0:39 ` Juri Linkov
2014-06-05 2:32 ` Leo Liu
2014-06-05 23:33 ` Juri Linkov
2014-06-06 9:28 ` Leo Liu
2014-06-06 23:07 ` Juri Linkov
2014-06-05 1:09 ` Glenn Morris
2014-06-05 2:40 ` Leo Liu
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.