From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs Date: Fri, 25 Jul 2014 14:34:28 -0700 Message-ID: <87ppgtt95n.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1406324188 20767 80.91.229.3 (25 Jul 2014 21:36:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Jul 2014 21:36:28 +0000 (UTC) To: 18110@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 25 23:36:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XAnA2-0004yo-Ts for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jul 2014 23:36:19 +0200 Original-Received: from localhost ([::1]:56929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAnA2-0005UH-Eu for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jul 2014 17:36:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAn9t-0005TG-5w for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:36:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAn9m-0000ar-IY for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:36:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAn9m-0000al-Es for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XAn9l-0002Xj-Qo for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jul 2014 21:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18110 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14063241109712 (code B ref -1); Fri, 25 Jul 2014 21:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jul 2014 21:35:10 +0000 Original-Received: from localhost ([127.0.0.1]:38116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAn8w-0002WZ-2n for submit@debbugs.gnu.org; Fri, 25 Jul 2014 17:35:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAn8t-0002WL-Qh for submit@debbugs.gnu.org; Fri, 25 Jul 2014 17:35:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAn8h-000080-OY for submit@debbugs.gnu.org; Fri, 25 Jul 2014 17:35:02 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAn8h-00007w-LW for submit@debbugs.gnu.org; Fri, 25 Jul 2014 17:34:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAn8b-0005Kj-EW for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:34:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAn8T-00006E-Jl for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:34:49 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAn8T-000060-BP for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 17:34:41 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by gateway1.nyi.internal (Postfix) with ESMTP id 87222222E7 for ; Fri, 25 Jul 2014 17:34:39 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 25 Jul 2014 17:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=from:to:subject:date:message-id:mime-version:content-type; s= mesmtp; bh=zElrPesuGqiVEOU8RmdFo8yeb2o=; b=IWAH/MFFfmA5Vlr0i+aH+ HZJPBzvjnbyuG4byDSooRvtElreR7mB8wm7MMXZtRsqgrbRrs/9I7gpM8BWRgckb nv4aJKulhXaPtCVWCdWrm2V+b6+OGkx+xiGxV8DEtM/wgEQ0vIHjWdpoRkQAqnIE TO5y5oxWdsXYPMJhm9vSVs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :mime-version:content-type; s=smtpout; bh=zElrPesuGqiVEOU8RmdFo8 yeb2o=; b=S8PqGGoexAJQGldXqZSuw0rPjxt5yhuzzAIprszTmnv0ojgjoo6/A1 DfgnEAxHtbY6oZHX7ZlrJ3djEBDrLqCLCkeCpqHuTk6nHjQpnFi4+SAUbsyuuhB0 DG4VuAqczCzttwb4e9ib3g/L786tpkW9DQztqZ0UztrYQR4b2WrqU= X-Sasl-enc: QzrNZAqA0/98lg1HDtk7cbIg87ewos/YG3EaXyCIPXe5 1406324079 Original-Received: from shorty.local (unknown [71.92.68.109]) by mail.messagingengine.com (Postfix) with ESMTPA id 50AFF6801B5 for ; Fri, 25 Jul 2014 17:34:39 -0400 (EDT) Original-Received: from ip6-localhost ([::1] helo=shorty.local) by shorty.local with esmtp (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1XAn8G-0001n9-7r for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 14:34:28 -0700 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91802 Archived-At: --=-=-= Content-Type: text/plain When looking at expanded git logs with vc-print-root-log (C-x v L, then by default), emacs was stripping out all leading whitespace from git logs. This was done by an (indent-region) call. This patch fixes this issue by removing this call. It might be good to remove a constant amount of whitespace from the beginning of each log line, but it's not obvious that matters, and it seems more trouble than it's worth. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-vc-git-expanded-log-entry-no-longer-strips-leading-w.patch >From 0b5ac295402eb99034602df352533f3b1d21fe24 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Fri, 25 Jul 2014 14:33:10 -0700 Subject: [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs When looking at expanded git logs with vc-print-root-log (C-x v L, then by default), emacs was stripping out all leading whitespace from git logs. This was done by an (indent-region) call. This patch fixes this issue by removing this call. It might be good to remove a constant amount of whitespace from the beginning of each log line, but it's not obvious that matters, and it seems more trouble than it's worth. --- lisp/vc/vc-git.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 9c8ab3b..a03ef0c 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -894,10 +894,7 @@ or BRANCH^ (where \"^\" can be repeated)." (with-temp-buffer (apply 'vc-git-command t nil nil (list "log" revision "-1")) (goto-char (point-min)) - (unless (eobp) - ;; Indent the expanded log entry. - (indent-region (point-min) (point-max) 2) - (buffer-string)))) + (unless (eobp) (buffer-string)))) (autoload 'vc-switches "vc") -- 2.0.0 --=-=-=--