From: Dima Kogan <dima@secretsauce.net>
To: 18110@debbugs.gnu.org
Subject: bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs
Date: Fri, 25 Jul 2014 14:34:28 -0700 [thread overview]
Message-ID: <87ppgtt95n.fsf@secretsauce.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
When looking at expanded git logs with vc-print-root-log (C-x v L, then <enter>
by default), emacs was stripping out all leading whitespace from git logs. This
was done by an (indent-region) call. This patch fixes this issue by removing
this call. It might be good to remove a constant amount of whitespace from the
beginning of each log line, but it's not obvious that matters, and it seems more
trouble than it's worth.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-vc-git-expanded-log-entry-no-longer-strips-leading-w.patch --]
[-- Type: text/x-diff, Size: 1277 bytes --]
From 0b5ac295402eb99034602df352533f3b1d21fe24 Mon Sep 17 00:00:00 2001
From: Dima Kogan <dima@secretsauce.net>
Date: Fri, 25 Jul 2014 14:33:10 -0700
Subject: [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace
from git logs
When looking at expanded git logs with vc-print-root-log (C-x v L, then <enter>
by default), emacs was stripping out all leading whitespace from git logs. This
was done by an (indent-region) call. This patch fixes this issue by removing
this call. It might be good to remove a constant amount of whitespace from the
beginning of each log line, but it's not obvious that matters, and it seems more
trouble than it's worth.
---
lisp/vc/vc-git.el | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 9c8ab3b..a03ef0c 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -894,10 +894,7 @@ or BRANCH^ (where \"^\" can be repeated)."
(with-temp-buffer
(apply 'vc-git-command t nil nil (list "log" revision "-1"))
(goto-char (point-min))
- (unless (eobp)
- ;; Indent the expanded log entry.
- (indent-region (point-min) (point-max) 2)
- (buffer-string))))
+ (unless (eobp) (buffer-string))))
(autoload 'vc-switches "vc")
--
2.0.0
next reply other threads:[~2014-07-25 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 21:34 Dima Kogan [this message]
2014-07-26 3:12 ` bug#18110: clarification Dima Kogan
2016-02-23 12:30 ` bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs Lars Ingebrigtsen
2016-02-24 0:25 ` Dmitry Gutov
2016-02-28 3:13 ` Dima Kogan
2016-02-28 4:48 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppgtt95n.fsf@secretsauce.net \
--to=dima@secretsauce.net \
--cc=18110@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.