From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#18373: desktop-create-buffer: may call bury-buffer on a just killed buffer (?) Date: Sun, 31 Aug 2014 21:31:41 +0000 Message-ID: <87ppfgtkg2.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1409520741 4346 80.91.229.3 (31 Aug 2014 21:32:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Aug 2014 21:32:21 +0000 (UTC) To: 18373@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 31 23:32:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XOCjO-0007m3-9l for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2014 23:32:14 +0200 Original-Received: from localhost ([::1]:51117 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOCjN-0006zo-T5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2014 17:32:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOCjH-0006yq-0L for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2014 17:32:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOCjC-0003Ok-Ml for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2014 17:32:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOCjC-0003Oc-Ey for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2014 17:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XOCjB-0000Pz-Vj for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2014 17:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Aug 2014 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14095207131586 (code B ref -1); Sun, 31 Aug 2014 21:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Aug 2014 21:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:55171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOCj3-0000PW-93 for submit@debbugs.gnu.org; Sun, 31 Aug 2014 17:31:53 -0400 Original-Received: from fely.am-1.org ([78.47.74.50]:52797) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOCj0-0000PM-G5 for submit@debbugs.gnu.org; Sun, 31 Aug 2014 17:31:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=l1lMXQb59bhIdo9wcI2rcalnl4qA4TpIImXrfUGViXs=; b=ciar0XJiuEOSOnz+vyM6sB7/cDVsSsEJCPtXcUD6M+6igHPjV9UhAr+xoCuvmFJRHyzUcHlG4oXB5NVaJjcALmjBasRHsEEUPUP0hiuVut4SxxR1CjRk1gz1tjMeZn9McEbE/s0n/Dvku/IRCBFlY8+oI3za2HZpukIYSF3NLRM=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XOCiy-0003ra-QV for submit@debbugs.gnu.org; Sun, 31 Aug 2014 21:31:49 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XOCir-0001MZ-R6 for submit@debbugs.gnu.org; Mon, 01 Sep 2014 04:31:41 +0700 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92904 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Tags: patch Currently, desktop-create-buffer calls bury-buffer on every buffer listed in a saved version of (buffer-list) so to restore the order of buffers: 1375 ;; Restore buffer list order with new buffer at end. Don't change 1376 ;; the order for old desktop files (old desktop module behavior). 1377 (unless (< desktop-file-version 206) 1378 (mapc 'bury-buffer buffer-list) 1379 (when result (bury-buffer result))) This, however, fails =E2=80=93 should one or more of these buffers be killed after the list is saved but before it=E2=80=99s processed, =E2=80= =93 as happens with some (presumably temporary) buffers used by url-retrieve, which is in turn used while restoring EWW buffers per [1]. (Please note that the patch there is broken, though.) The patch MIMEd seems to fix the issue for me, although I=E2=80=99m not as of yet certain that no buffer can be killed in between the buffer-live-p check and the bury-buffer call. [1] http://debbugs.gnu.org/18010 --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/desktop.el +++ b/lisp/desktop.el @@ -1375,7 +1375,10 @@ after that many seconds of idle time." ;; Restore buffer list order with new buffer at end. Don't change ;; the order for old desktop files (old desktop module behavior). (unless (< desktop-file-version 206) - (mapc 'bury-buffer buffer-list) + (mapc (lambda (buf) + (and (buffer-live-p buf) + (bury-buffer buf))) + buffer-list) (when result (bury-buffer result))) (when result (unless (or desktop-first-buffer (< desktop-file-version 206)) --=-=-=--