From: Ivan Shmakov <ivan@siamics.net>
To: 18551@debbugs.gnu.org
Cc: kelvin white <kwhite@gnu.org>
Subject: bug#18551: regression: erc-format-nick is now essentially an alias to eww-format-@nick
Date: Wed, 24 Sep 2014 21:33:57 +0000 [thread overview]
Message-ID: <87ppekn1oa.fsf@violet.siamics.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]
Package: emacs
X-Debbugs-Cc: Kelvin White <kwhite@gnu.org>
The following change (present as of 0ee10aff098b) was introduced
into lisp/erc/erc.el back this June:
commit b45734ee82eecb91010eb3055c8c8bafb73a3ade
Author: Kelvin White <kelvin.white77@gmail.com>
AuthorDate: Thu Jun 19 12:56:18 2014 -0400
ERC: Better user mode support
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
…
@@ -4190,7 +4223,24 @@
(defun erc-format-nick (&optional user _channel-data)
"Return the nickname of USER.
See also `erc-format-nick-function'."
- (when user (erc-server-user-nickname user)))
+ (let ((nick (erc-server-user-nickname user)))
+ (concat (erc-propertize
+ (erc-get-user-mode-prefix nick)
+ 'face 'erc-nick-prefix-face) nick)))
…
This added the “user mode” sign – previously kind of specific to
erc-format-@nick – into the string returned by erc-format-nick.
Thus, the only code difference left between the two is the
(presumably accidental) lack of the (when user …) in the former:
4227 (defun erc-format-nick (&optional user _channel-data)
…
4230 (let ((nick (erc-server-user-nickname user)))
4231 (concat (erc-propertize
4232 (erc-get-user-mode-prefix nick)
4233 'face 'erc-nick-prefix-face)
4234 nick)))
4250 (defun erc-format-@nick (&optional user channel-data)
…
4256 (when user
4257 (let ((nick (erc-server-user-nickname user)))
4258 (concat (erc-propertize
4259 (erc-get-user-mode-prefix nick)
4260 'face 'erc-nick-prefix-face)
4261 nick))))
I believe that this change was unintended, is not helpful in any
way (if the intent was to get rid of the former, it should’ve
been aliased over, not redefined, shouldn’t it?), and should
thus be reverted.
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 479 bytes --]
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4227,11 +4227,7 @@
(defun erc-format-nick (&optional user _channel-data)
"Return the nickname of USER.
See also `erc-format-nick-function'."
- (let ((nick (erc-server-user-nickname user)))
- (concat (erc-propertize
- (erc-get-user-mode-prefix nick)
- 'face 'erc-nick-prefix-face)
- nick)))
+ (when user (erc-server-user-nickname user)))
(defun erc-get-user-mode-prefix (user)
(when user
next reply other threads:[~2014-09-24 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 21:33 Ivan Shmakov [this message]
2014-11-21 19:31 ` bug#18551: regression: erc-format-nick is now essentially an alias to eww-format-@nick Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppekn1oa.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=18551@debbugs.gnu.org \
--cc=kwhite@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.