From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: vc-git-previous-revision and cmd.exe Date: Mon, 17 Nov 2014 18:55:10 +0100 Message-ID: <87ppcl1zlt.fsf@igel.home> References: <83bno5bwir.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416246962 11017 80.91.229.3 (17 Nov 2014 17:56:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Nov 2014 17:56:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 17 18:55:55 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XqQWn-0003JO-Ri for ged-emacs-devel@m.gmane.org; Mon, 17 Nov 2014 18:55:53 +0100 Original-Received: from localhost ([::1]:49514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQWn-0006Cl-Hk for ged-emacs-devel@m.gmane.org; Mon, 17 Nov 2014 12:55:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQWK-0006Ay-Ja for emacs-devel@gnu.org; Mon, 17 Nov 2014 12:55:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqQWF-00066S-5E for emacs-devel@gnu.org; Mon, 17 Nov 2014 12:55:24 -0500 Original-Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:34703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQW9-00060U-92; Mon, 17 Nov 2014 12:55:13 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3jhHxW67vjz3hjcQ; Mon, 17 Nov 2014 18:55:11 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3jhHxW5WhCzvh1m; Mon, 17 Nov 2014 18:55:11 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 05WxoHXXKoar; Mon, 17 Nov 2014 18:55:11 +0100 (CET) X-Auth-Info: eqJo92RTH1rPmmVqQte4mRPsa2VJw7HBsQLmt1FgdCC2leJXj7LK9X0MLZAhwj2P Original-Received: from igel.home (ppp-188-174-153-115.dynamic.mnet-online.de [188.174.153.115]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 17 Nov 2014 18:55:11 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id C32662C3747; Mon, 17 Nov 2014 18:55:10 +0100 (CET) X-Yow: HELLO, little boys! Gimme a MINT TULIP!! Let's do the BOSSA NOVA!! In-Reply-To: <83bno5bwir.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 Nov 2014 18:51:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 2001:a60:0:28:0:1:25:1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177464 Archived-At: Eli Zaretskii writes: > vc-git-previous-revision appends "^" to a revision to get the previous > one. But "^" is a special character for the Windows cmd.exe shell, so > 'D' in the *vc-change-log* buffer doesn't work if the 'git' command is > actually a batch file that invokes the real Git executable, in which > case we call cmd.exe to run the batch file, and cmd.exe removes the ^ > (because it's the escape character). Why is that a problem? process-file should properly quote the arguments when it needs to go through a shell. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."