From: Ivan Shmakov <ivan@siamics.net>
To: 19101@debbugs.gnu.org
Subject: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode
Date: Wed, 19 Nov 2014 16:51:13 +0000 [thread overview]
Message-ID: <87ppcj3zi6.fsf@violet.siamics.net> (raw)
In-Reply-To: <83d28j88ws.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Nov 2014 18:14:27 +0200")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov <ivan@siamics.net>
>>>>> Richard Copley <rcopley@gmail.com> writes:
>>> Visit a file under Subversion or RCS (not Git or Bazaar) and invoke
>>> `vc-print-log'. The log buffer should be put into log-view-mode,
>>> but it isn't. The buffer visiting the file is put into
>>> log-view-mode instead.
>> This is likely to be caused by VC assuming that the ‘print-log’
>> backend function leaves the log buffer as the current one.
> No, it's because Stefan moved the call to pop-to-buffer so that the
> part that turned on the mode was running in the wrong buffer.
ACK, but that change seem to be dated 2014-11-05, while I’ve
observed a similar issue (with non-Emacs code, though) before.
Or so I think.
> As for print-log backend function, those that I saw run inside
> with-temp-buffer, so they don't switch buffers.
There’re several which use vc-setup-buffer, which in turn calls
set-buffer. Consider, e. g.:
(defun vc-setup-buffer (buf)
"Prepare BUF for executing a slave command and make it current."
(let ((camefrom (current-buffer))
(olddir default-directory))
(set-buffer (get-buffer-create buf))
(defun vc-bzr-print-log (files buffer &optional shortlog start-revision limit)
…
;; `vc-do-command' creates the buffer, but we need it before running
;; the command.
(vc-setup-buffer buffer)
(defun vc-git-print-log (files buffer &optional shortlog start-revision limit)
…
(let ((coding-system-for-read vc-git-commits-coding-system))
;; `vc-do-command' creates the buffer, but we need it before running
;; the command.
(vc-setup-buffer buffer)
(defun vc-hg-print-log (files buffer &optional shortlog start-revision limit)
…
;; `vc-do-command' creates the buffer, but we need it before running
;; the command.
(vc-setup-buffer buffer)
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2014-11-19 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 1:17 bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' Richard Copley
2014-11-19 6:53 ` bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode Ivan Shmakov
2014-11-19 16:14 ` Eli Zaretskii
2014-11-19 16:51 ` Ivan Shmakov [this message]
2014-11-19 18:52 ` Eli Zaretskii
2014-11-20 11:17 ` Ivan Shmakov
2014-11-19 16:12 ` bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' Eli Zaretskii
2014-11-19 19:04 ` Richard Copley
2014-11-19 19:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppcj3zi6.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19101@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.