From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: handa@gnu.org (K. Handa) Newsgroups: gmane.emacs.bugs Subject: bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes Date: Sun, 15 Feb 2015 22:47:06 +0900 Message-ID: <87pp9be17p.fsf@gnu.org> References: <878uj674zh.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424008110 32634 80.91.229.3 (15 Feb 2015 13:48:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Feb 2015 13:48:30 +0000 (UTC) Cc: dima@secretsauce.net To: 19117@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 15 14:48:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMzYW-0005AF-7H for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Feb 2015 14:48:16 +0100 Original-Received: from localhost ([::1]:35461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMzYV-0002B8-B8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Feb 2015 08:48:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMzYN-0002A0-F4 for bug-gnu-emacs@gnu.org; Sun, 15 Feb 2015 08:48:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMzYI-0003hQ-OI for bug-gnu-emacs@gnu.org; Sun, 15 Feb 2015 08:48:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMzYI-0003hL-L7 for bug-gnu-emacs@gnu.org; Sun, 15 Feb 2015 08:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YMzYI-0008QV-88 for bug-gnu-emacs@gnu.org; Sun, 15 Feb 2015 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: handa@gnu.org (K. Handa) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Feb 2015 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19117-submit@debbugs.gnu.org id=B19117.142400804732348 (code B ref 19117); Sun, 15 Feb 2015 13:48:02 +0000 Original-Received: (at 19117) by debbugs.gnu.org; 15 Feb 2015 13:47:27 +0000 Original-Received: from localhost ([127.0.0.1]:44435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMzXi-0008Pg-Qf for submit@debbugs.gnu.org; Sun, 15 Feb 2015 08:47:27 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:52011 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMzXg-0008PX-3S for 19117@debbugs.gnu.org; Sun, 15 Feb 2015 08:47:24 -0500 Original-Received: from fl1-122-134-99-48.iba.mesh.ad.jp ([122.134.99.48]:52442 helo=shatin) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YMzXf-0003l3-57; Sun, 15 Feb 2015 08:47:23 -0500 Original-Received: from handa by shatin with local (Exim 4.82) (envelope-from ) id 1YMzXT-0005LC-V7; Sun, 15 Feb 2015 22:47:12 +0900 In-Reply-To: <87bnl9nkqe.fsf@gnu.org> (message from handa on Thu, 05 Feb 2015 11:41:13 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99432 Archived-At: In article <87bnl9nkqe.fsf@gnu.org>, handa writes: > In article , Stefan Monnier writes: > > > This is a gentle ping. Is there anything more I can do to get this > > > merged? > > I could install it, but I really have no idea whether your patch does > > the right thing, because I'm too unfamiliar with this code. > > Jan? Handa? Sorry for the late response. I agree that the patch is doing the correct thing, but it seems that it overlooks the case of scalable-fonts-allowed being a cons: else if (CONSP (Vscalable_fonts_allowed)) { Lisp_Object tail; for (tail = Vscalable_fonts_allowed; CONSP (tail); tail = XCDR (tail)) { Lisp_Object elt = XCAR (tail); if (STRINGP (elt) && (fast_c_string_match_ignore_case (elt, indices[i], len) >= 0)) break; } if (! CONSP (tail)) continue; } Here too, skipped_some_scalable_fonts must be set to true before "continue;". And, one trivial comment on ChangeLog entry :-p * xfaces.c (realize_basic_faces): Don't set Qscalable_fonts_allowed to t. Isn't it better to use the pair Qscalable_fonts_allowed and Qt, or the pair scalable-fonts-allowed and t? --- Kenichi Handa handa@gnu.org