From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20117: 25.0.50; Tramp tests failing on Cygwin Date: Tue, 17 Mar 2015 20:16:53 +0100 Message-ID: <87pp87v3h6.fsf@gmx.de> References: <5506F003.1070201@cornell.edu> <87mw3c93tp.fsf@gmx.de> <550743AF.5050708@cornell.edu> <55086CC7.3090807@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426619845 17048 80.91.229.3 (17 Mar 2015 19:17:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Mar 2015 19:17:25 +0000 (UTC) Cc: 20117@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 17 20:17:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXwzJ-0002z8-V4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Mar 2015 20:17:14 +0100 Original-Received: from localhost ([::1]:56600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXwzJ-0000il-9S for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Mar 2015 15:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXwzE-0000fC-59 for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2015 15:17:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXwz9-0005U9-2g for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2015 15:17:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXwz9-0005U4-0Y for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2015 15:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YXwz8-00060f-Fh for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2015 15:17:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <5506F003.1070201@cornell.edu> Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Mar 2015 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20117-submit@debbugs.gnu.org id=B20117.142661982023090 (code B ref 20117); Tue, 17 Mar 2015 19:17:02 +0000 Original-Received: (at 20117) by debbugs.gnu.org; 17 Mar 2015 19:17:00 +0000 Original-Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXwz5-00060L-Ao for submit@debbugs.gnu.org; Tue, 17 Mar 2015 15:16:59 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:57998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXwz3-00060B-4y for 20117@debbugs.gnu.org; Tue, 17 Mar 2015 15:16:58 -0400 Original-Received: from detlef.gmx.de ([87.146.33.28]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LbMmA-1ZEOT61Ngg-00l0eR; Tue, 17 Mar 2015 20:16:54 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:6j0ntky3VA42CEDBCzq7eU2tCAfXshJgjaKZXEwk4vaez56Z9GN duwp+sQfcIlQXA3J5m+i9utWwbQxdLMn4ekbVPglm+a5fABujqTQ5qSxUSGlUUIJM7ZXINU /F3u6l3TFmJ1qyir3hqKZIhVwG1hJwCfHU5m1bMhZQqUNbcEyZ2fw2xoRkgoiO+53kegLES 58W/1Z2o/Jiw5NoH/hUJQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100600 Archived-At: Ken Brown writes: > In case it helps, here's the complete list of Tramp tests that > currently abort on Cygwin: > > tramp-test19-directory-files-and-attributes > tramp-test30-special-characters > tramp-test30-special-characters-with-stat > tramp-test31-utf8 > tramp-test31-utf8-with-stat > > I've instrumented all of them and can make the traces available to you > if it would help. The four new ones come to more than 9MB, after > tarring and compressing. Likely, all of them are caused by the same problem. The traces you have sent to me for tramp-test19-directory-files-and-attributes indicate a problem with the marker I have introduced in order to handle apostrophs in file names properly. I could reproduce it locally with bash and zsh; other bournish shells like ksh and dash work properly. The following patch let the construct work in all four investigated shells for me, could you pls check? --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/tramp/lisp/tramp-sh.el.~master~ 2015-03-17 20:12:48.781125579 +0100 --- /home/albinus/src/tramp/lisp/tramp-sh.el 2015-03-17 20:05:35.432048823 +0100 *************** *** 1719,1730 **** ;; "-"; this would confuse xargs. "ls -aQ" might be a solution, ;; but it does not work on all remote systems. Therefore, we ;; use \000 as file separator. ! ;; Apostrophes in the stat output are masked as \037 characters, in ;; order to make a proper shell escape of them in file names. "cd %s && echo \"(\"; (%s %s -a | " "xargs %s -c " ! "'(\037%%n\037 (\037%%N\037) %%h %s %s %%Xe0 %%Ye0 %%Ze0 %%se0 \037%%A\037 t %%ie0 -1)'" ! " -- 2>/dev/null | sed -e 's/\"/\\\\\"/g' -e 's/\037/\"/g'); echo \")\"") (tramp-shell-quote-argument localname) (tramp-get-ls-command vec) ;; On systems which have no quoting style, file names with --- 1719,1730 ---- ;; "-"; this would confuse xargs. "ls -aQ" might be a solution, ;; but it does not work on all remote systems. Therefore, we ;; use \000 as file separator. ! ;; Apostrophes in the stat output are masked as \006 characters, in ;; order to make a proper shell escape of them in file names. "cd %s && echo \"(\"; (%s %s -a | " "xargs %s -c " ! "'(\006%%n\006 (\006%%N\006) %%h %s %s %%Xe0 %%Ye0 %%Ze0 %%se0 \006%%A\006 t %%ie0 -1)'" ! " -- 2>/dev/null | sed -e 's/\"/\\\\\"/g' -e 's/\006/\"/g'); echo \")\"") (tramp-shell-quote-argument localname) (tramp-get-ls-command vec) ;; On systems which have no quoting style, file names with *************** *** 1732,1739 **** (if (tramp-get-ls-command-with-quoting-style vec) "--quoting-style=shell" "") (tramp-get-remote-stat vec) ! (if (eq id-format 'integer) "%ue0" "\037%U\037") ! (if (eq id-format 'integer) "%ge0" "\037%G\037")))) ;; This function should return "foo/" for directories and "bar" for ;; files. --- 1732,1739 ---- (if (tramp-get-ls-command-with-quoting-style vec) "--quoting-style=shell" "") (tramp-get-remote-stat vec) ! (if (eq id-format 'integer) "%ue0" "\006%U\006") ! (if (eq id-format 'integer) "%ge0" "\006%G\006")))) ;; This function should return "foo/" for directories and "bar" for ;; files. --8<---------------cut here---------------end--------------->8--- > Ken Best regards, Michael.