From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20943: 25.0.50; Dired buffers are not always auto-reverted Date: Thu, 16 Jul 2015 20:12:04 +0200 Message-ID: <87pp3sdlaj.fsf@gmx.de> References: <87y4j1oy87.fsf@openmailbox.org> <87pp41cvl1.fsf@openmailbox.org> <83615tv14o.fsf@gnu.org> <874mldtkl9.fsf@openmailbox.org> <874mld18cx.fsf@gmx.de> <87io9t3yoh.fsf@openmailbox.org> <83r3ogbm4s.fsf@gnu.org> <87vbdszh2r.fsf@gmx.de> <83lheobi8x.fsf@gnu.org> <87pp40z9fp.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1437070403 23692 80.91.229.3 (16 Jul 2015 18:13:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jul 2015 18:13:23 +0000 (UTC) Cc: 20943@debbugs.gnu.org, markkarpov@openmailbox.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 16 20:13:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZFneg-00026t-HO for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jul 2015 20:13:10 +0200 Original-Received: from localhost ([::1]:41427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFnef-0003mw-P2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jul 2015 14:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFnec-0003mp-Js for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2015 14:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFneY-0007gK-Hi for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2015 14:13:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFneY-0007gG-Ej for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2015 14:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZFneX-0002cx-Vj for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2015 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2015 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20943-submit@debbugs.gnu.org id=B20943.143707033510041 (code B ref 20943); Thu, 16 Jul 2015 18:13:01 +0000 Original-Received: (at 20943) by debbugs.gnu.org; 16 Jul 2015 18:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:51375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFndm-0002bt-M3 for submit@debbugs.gnu.org; Thu, 16 Jul 2015 14:12:14 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:60418) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFndk-0002bf-E2 for 20943@debbugs.gnu.org; Thu, 16 Jul 2015 14:12:13 -0400 Original-Received: from detlef.gmx.de ([93.209.82.104]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Mhdex-1Zasr948Dj-00Mtbp; Thu, 16 Jul 2015 20:12:05 +0200 In-Reply-To: <87pp40z9fp.fsf@gmx.de> (Michael Albinus's message of "Fri, 10 Jul 2015 10:46:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:t957vQBYlx5mTFoeKRWkvz2ykXC8zi0K8MapTEkTHCYQhDOR4oA mvwZxrYMFRXMiO0UUnYYBNA1ThPorXMKnMl1489wlzAaLBYZinDLp8lRzukrBf1H8cLJlxP ibYa/adngFN+MFvBZEFoHyzUMC6jiNM6+fIOuQvKmMA1jcKR5qxpXVrOlBm2cCO92ptunUM o1jAekKXoWYRu0k0YR/Dw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Rb4ZwXZVHSE=:9Dqeyisr6NVNZUhr6MS8bl TK1DTRK+fR4/caxURhySdpM3S1mFK545+21mFNPgoECtsFGRq7RESBScPVsfxRNau6t5UOgLm coMBsYxFLaMWjH1YiIjV0BII6ncZRqnXo0TCShbghhDAqC8JTZu8wWXGV7lhQ/8OcHWXRDi2T nxSu6EdzsQ9SV+4Io+V8Q0MBRsVYHgLCchTjVl+ShqEeLAje+pmyWU4qgbrZJQi8c7cUXO554 nGEQ2t+/ydRSc0HOId5mxxIfyUPiHk6G8N33VMaw78V3BGv6m8kpYZf6QYOYUXONEBY7neFi9 l0qbwX2+mQNtG803qe8jwj10SuZEE9xhpFSG1A737eSFLKLFfgt5bkMQVn/ZJE3L0nOavsIvw s6aPHzPhZwfN3UIM3g1+ekpX3Eh6YZwombGi6KWrZGUODhrF6Va3ro8d8U6VPWSFW/N+ryXEi mS/lqvJmh0gNT/Xy1Wx2aAYR1RXG+pZZbl6vatoJsSSDOveX+b3daP0nsFZBjetxytvdU9TRK 1yhGjwDnJT4IoMqoYGPjkEO40HPIBoMVmIk/wkeHuYp2hC55HWyAbMPizFGx86VRLBh4JB+q6 vum8kZnkfO3de4XoPkq08s9kKn/5swVbg3VAE/ab/6505v7I0GC9KcXoZ+QQjQwony5NXhBWV myB2Jc6hA+nrg8no31uvj7JiRKrsS5SE92esVYypBQnh64GUEhufYT6odzuZFp9ZEv6Y= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104994 Archived-At: Michael Albinus writes: >> What Mark was trying to tell you is that dired-stale-p is not even >> called when buffer-modified-p returns non-nil. So what you suggest is >> impossible without a thorough rewrite of the beginning of >> auto-revert-handler. > > That's why I have proposed to remove the buffer-modified-p check from > auto-revert-handler. It shall be checked in -stale-p, if desired. I've committed a patch to the trunk which implements it. auto-revert-tests.el seems to be happy with this (no surprise, it's written by me :-) Mark, could you check whether this is sufficient for you? There is still a check in dired-buffer-stale-p: ;; Do not auto-revert when the dired buffer can be currently ;; written by the user as in `wdired-mode'. buffer-read-only Don't know whether it affects your use case. And likely, doc/emacs/arevert-xtra.texi must be adapted too, haven't done this yet. I'm waiting, whether the fix flies. Best regards, Michael.